Skip to content

Commit 70bd4a5

Browse files
author
James DeFelice
committed
address review feedback
1 parent 6837c76 commit 70bd4a5

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

csi.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,8 @@ message VolumeCapability {
187187
// The mount options that can be used for the volume. This field is
188188
// OPTIONAL. `mount_flags` MAY contain sensitive information.
189189
// Therefore, the CO and the Plugin MUST NOT leak this information
190-
// to untrusted entities.
190+
// to untrusted entities. The total size of this repeated field
191+
// SHALL NOT exceed 4 KiB.
191192
repeated string mount_flags = 2;
192193
}
193194

lib/go/csi/csi.pb.go

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,13 +299,13 @@ The error code `OPERATION_PENDING_FOR_VOLUME` may be returned by the plugin in t
299299

300300
CSI defines general size limits for fields of various types (see table below).
301301
The general size limit for a particular field may be overridden by specifying a different size limit in said field's description.
302-
The general size limits apply for messages generated by both COs and plugins.
302+
Unless otherwise specified, fields SHALL NOT exceed the limits documented here.
303+
These limits apply for messages generated by both COs and plugins.
303304

304305
| Size | Field Type |
305306
|------------|---------------------|
306307
| 128 bytes | string |
307308
| 4 KiB | map<string, string> |
308-
| 4 KiB | repeated string |
309309

310310
### Identity Service RPC
311311

@@ -494,7 +494,8 @@ message VolumeCapability {
494494
// The mount options that can be used for the volume. This field is
495495
// OPTIONAL. `mount_flags` MAY contain sensitive information.
496496
// Therefore, the CO and the Plugin MUST NOT leak this information
497-
// to untrusted entities.
497+
// to untrusted entities. The total size of this repeated field
498+
// SHALL NOT exceed 4 KiB.
498499
repeated string mount_flags = 2;
499500
}
500501

0 commit comments

Comments
 (0)