Skip to content

Commit a40cf31

Browse files
committed
Bump tags.cncf.io/container-device-interface to v0.7.1
This includes migrating from cdi.GetRegistry() to cdi.Configure() and cdi.GetDefaultCache() as applicable. Signed-off-by: Evan Lezar <[email protected]>
1 parent 19600fa commit a40cf31

File tree

18 files changed

+287
-149
lines changed

18 files changed

+287
-149
lines changed

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ require (
9494
gopkg.in/inf.v0 v0.9.1
9595
gopkg.in/yaml.v3 v3.0.1
9696
sigs.k8s.io/yaml v1.4.0
97-
tags.cncf.io/container-device-interface v0.6.2
97+
tags.cncf.io/container-device-interface v0.7.1
9898
)
9999

100100
require (
@@ -238,7 +238,7 @@ require (
238238
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
239239
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
240240
gopkg.in/yaml.v2 v2.4.0 // indirect
241-
tags.cncf.io/container-device-interface/specs-go v0.6.0 // indirect
241+
tags.cncf.io/container-device-interface/specs-go v0.7.0 // indirect
242242
)
243243

244244
replace github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.1-0.20240131200429-02120488a4c0

go.sum

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ rsc.io/pdf v0.1.1/go.mod h1:n8OzWcQ6Sp37PL01nO98y4iUCRdTGarVfzxY20ICaU4=
852852
sigs.k8s.io/yaml v1.4.0 h1:Mk1wCc2gy/F0THH0TAp1QYyJNzRm2KCLy3o5ASXVI5E=
853853
sigs.k8s.io/yaml v1.4.0/go.mod h1:Ejl7/uTz7PSA4eKMyQCUTnhZYNmLIl+5c2lQPGR2BPY=
854854
src.elv.sh v0.16.0-rc1.0.20220116211855-fda62502ad7f h1:pjVeIo9Ba6K1Wy+rlwX91zT7A+xGEmxiNRBdN04gDTQ=
855-
tags.cncf.io/container-device-interface v0.6.2 h1:dThE6dtp/93ZDGhqaED2Pu374SOeUkBfuvkLuiTdwzg=
856-
tags.cncf.io/container-device-interface v0.6.2/go.mod h1:Shusyhjs1A5Na/kqPVLL0KqnHQHuunol9LFeUNkuGVE=
857-
tags.cncf.io/container-device-interface/specs-go v0.6.0 h1:V+tJJN6dqu8Vym6p+Ru+K5mJ49WL6Aoc5SJFSY0RLsQ=
858-
tags.cncf.io/container-device-interface/specs-go v0.6.0/go.mod h1:hMAwAbMZyBLdmYqWgYcKH0F/yctNpV3P35f+/088A80=
855+
tags.cncf.io/container-device-interface v0.7.1 h1:MATNCbAD1su9U6zwQe5BrQ2vGGp1GBayD70bYaxYCNE=
856+
tags.cncf.io/container-device-interface v0.7.1/go.mod h1:h1JVuOqTQVORp8DziaWKUCDNzAmN+zeCbqbqD30D0ZQ=
857+
tags.cncf.io/container-device-interface/specs-go v0.7.0 h1:w/maMGVeLP6TIQJVYT5pbqTi8SCw/iHZ+n4ignuGHqg=
858+
tags.cncf.io/container-device-interface/specs-go v0.7.0/go.mod h1:hMAwAbMZyBLdmYqWgYcKH0F/yctNpV3P35f+/088A80=

libpod/container_internal_common.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -564,14 +564,16 @@ func (c *Container) generateSpec(ctx context.Context) (s *spec.Spec, cleanupFunc
564564

565565
// Warning: CDI may alter g.Config in place.
566566
if len(c.config.CDIDevices) > 0 {
567-
registry := cdi.GetRegistry(
567+
registry, err := cdi.NewCache(
568568
cdi.WithAutoRefresh(false),
569569
)
570+
if err != nil {
571+
return nil, nil, fmt.Errorf("creating CDI registry: %w", err)
572+
}
570573
if err := registry.Refresh(); err != nil {
571574
logrus.Debugf("The following error was triggered when refreshing the CDI registry: %v", err)
572575
}
573-
_, err := registry.InjectDevices(g.Config, c.config.CDIDevices...)
574-
if err != nil {
576+
if _, err := registry.InjectDevices(g.Config, c.config.CDIDevices...); err != nil {
575577
return nil, nil, fmt.Errorf("setting up CDI devices: %w", err)
576578
}
577579
}

pkg/specgen/generate/config_freebsd.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,16 @@ import (
1818
// DevicesFromPath computes a list of devices
1919
func DevicesFromPath(g *generate.Generator, devicePath string) error {
2020
if isCDIDevice(devicePath) {
21-
registry := cdi.GetRegistry(
21+
registry, err := cdi.NewCache(
2222
cdi.WithAutoRefresh(false),
2323
)
24+
if err != nil {
25+
return fmt.Errorf("creating CDI registry: %w", err)
26+
}
2427
if err := registry.Refresh(); err != nil {
2528
logrus.Debugf("The following error was triggered when refreshing the CDI registry: %v", err)
2629
}
27-
_, err := registry.InjectDevices(g.Config, devicePath)
28-
if err != nil {
30+
if _, err = registry.InjectDevices(g.Config, devicePath); err != nil {
2931
return fmt.Errorf("setting up CDI devices: %w", err)
3032
}
3133
return nil

pkg/specgen/generate/config_linux.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,16 @@ import (
2525
// DevicesFromPath computes a list of devices
2626
func DevicesFromPath(g *generate.Generator, devicePath string) error {
2727
if isCDIDevice(devicePath) {
28-
registry := cdi.GetRegistry(
28+
registry, err := cdi.NewCache(
2929
cdi.WithAutoRefresh(false),
3030
)
31+
if err != nil {
32+
return fmt.Errorf("creating CDI registry: %w", err)
33+
}
3134
if err := registry.Refresh(); err != nil {
3235
logrus.Debugf("The following error was triggered when refreshing the CDI registry: %v", err)
3336
}
34-
_, err := registry.InjectDevices(g.Config, devicePath)
35-
if err != nil {
37+
if _, err := registry.InjectDevices(g.Config, devicePath); err != nil {
3638
return fmt.Errorf("setting up CDI devices: %w", err)
3739
}
3840
return nil

vendor/modules.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1397,14 +1397,13 @@ gopkg.in/yaml.v3
13971397
## explicit; go 1.12
13981398
sigs.k8s.io/yaml
13991399
sigs.k8s.io/yaml/goyaml.v2
1400-
# tags.cncf.io/container-device-interface v0.6.2
1401-
## explicit; go 1.19
1402-
tags.cncf.io/container-device-interface/internal/multierror
1400+
# tags.cncf.io/container-device-interface v0.7.1
1401+
## explicit; go 1.20
14031402
tags.cncf.io/container-device-interface/internal/validation
14041403
tags.cncf.io/container-device-interface/internal/validation/k8s
14051404
tags.cncf.io/container-device-interface/pkg/cdi
14061405
tags.cncf.io/container-device-interface/pkg/parser
1407-
# tags.cncf.io/container-device-interface/specs-go v0.6.0
1406+
# tags.cncf.io/container-device-interface/specs-go v0.7.0
14081407
## explicit; go 1.19
14091408
tags.cncf.io/container-device-interface/specs-go
14101409
# github.com/opencontainers/runc => github.com/opencontainers/runc v1.1.1-0.20240131200429-02120488a4c0

vendor/tags.cncf.io/container-device-interface/internal/multierror/multierror.go

Lines changed: 0 additions & 82 deletions
This file was deleted.

vendor/tags.cncf.io/container-device-interface/internal/validation/k8s/objectmeta.go

Lines changed: 5 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/tags.cncf.io/container-device-interface/pkg/cdi/cache.go

Lines changed: 30 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)