Skip to content

Conversation

@exigow
Copy link
Collaborator

@exigow exigow commented Jul 24, 2025

The previous homebrew-17 is specific to macOS and requires switching to JAVA_HOME on Windows/Linux.

Workaround: ./idea/gradle.xml can be marked as unstaged file in Git, but this is inconvenient.

JAVA_HOME is the most OS-agnostic value IMO.


Summary by cubic

Switched Gradle JVM setting in .idea/gradle.xml from the macOS-specific "homebrew-17" to use JAVA_HOME for better cross-platform support.

@exigow exigow requested a review from Patrick-Erichsen July 24, 2025 14:00
@exigow exigow requested a review from a team as a code owner July 24, 2025 14:00
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 24, 2025
The previous homebrew-17 is specific to macOS and requires switching to JAVA_HOME on Windows/Linux.

Workaround: ./idea/gradle.xml can be marked as unstaged, but this is inconvenient for developers.

JAVA_HOME is a standard IMO.
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 92f4944 into main Jul 24, 2025
77 of 80 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the exigow/fix-gradle-jvm branch July 24, 2025 19:46
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 24, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@sestinj
Copy link
Contributor

sestinj commented Jul 24, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Jul 28, 2025

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants