Gracefully handle TERM signal in proxy and other sidecar containers (#2402)

Author: deliahu

cmd/activator/main.go

@@ -24,6 +24,7 @@ import (
 	"os/signal"
 	"strconv"
 	"strings"
+	"syscall"
 	"time"
 
 	"github.com/cortexlabs/cortex/pkg/activator"
@@ -167,14 +168,13 @@ func main() {
 	}
 
 	sigint := make(chan os.Signal, 1)
-	signal.Notify(sigint, os.Interrupt)
+	signal.Notify(sigint, os.Interrupt, syscall.SIGTERM)
 
 	select {
 	case err = <-errCh:
 		exit(log, err, "failed to start activator server")
 	case <-sigint:
-		// We received an interrupt signal, shut down.
-		log.Info("Received TERM signal, handling a graceful shutdown...")
+		log.Info("Received INT or TERM signal, handling a graceful shutdown...")
 
 		for name, server := range servers {
 			log.Infof("Shutting down %s server", name)

cmd/autoscaler/main.go

@@ -25,6 +25,7 @@ import (
 	"os/signal"
 	"strconv"
 	"strings"
+	"syscall"
 	"time"
 
 	"github.com/cortexlabs/cortex/pkg/autoscaler"
@@ -225,14 +226,13 @@ func main() {
 	}()
 
 	sigint := make(chan os.Signal, 1)
-	signal.Notify(sigint, os.Interrupt)
+	signal.Notify(sigint, os.Interrupt, syscall.SIGTERM)
 
 	select {
 	case err = <-errCh:
 		exit(log, err, "failed to start autoscaler server")
 	case <-sigint:
-		// We received an interrupt signal, shut down.
-		log.Info("Received TERM signal, handling a graceful shutdown...")
+		log.Info("Received INT or TERM signal, handling a graceful shutdown...")
 		log.Info("Shutting down server")
 		if err = server.Shutdown(context.Background()); err != nil {
 			// Error from closing listeners, or context timeout:

cmd/dequeuer/main.go

@@ -23,6 +23,7 @@ import (
 	"os"
 	"os/signal"
 	"strconv"
+	"syscall"
 
 	"github.com/DataDog/datadog-go/statsd"
 	"github.com/cortexlabs/cortex/pkg/consts"
@@ -210,7 +211,7 @@ func main() {
 	}()
 
 	sigint := make(chan os.Signal, 1)
-	signal.Notify(sigint, os.Interrupt)
+	signal.Notify(sigint, os.Interrupt, syscall.SIGTERM)
 
 	sqsDequeuer, err := dequeuer.NewSQSDequeuer(dequeuerConfig, awsClient, log)
 	if err != nil {
@@ -239,7 +240,7 @@ func main() {
 	case err = <-errCh:
 		exit(log, err, "error during message dequeueing or error from admin server")
 	case <-sigint:
-		log.Info("Received TERM signal, handling a graceful shutdown...")
+		log.Info("Received INT or TERM signal, handling a graceful shutdown...")
 		sqsDequeuer.Shutdown()
 		log.Info("Shutdown complete, exiting...")
 	}

cmd/proxy/main.go

@@ -25,6 +25,7 @@ import (
 	"os"
 	"os/signal"
 	"strconv"
+	"syscall"
 	"time"
 
 	"github.com/cortexlabs/cortex/pkg/lib/aws"
@@ -167,14 +168,13 @@ func main() {
 	}
 
 	sigint := make(chan os.Signal, 1)
-	signal.Notify(sigint, os.Interrupt)
+	signal.Notify(sigint, os.Interrupt, syscall.SIGTERM)
 
 	select {
 	case err = <-errCh:
 		exit(log, errors.Wrap(err, "failed to start proxy server"))
 	case <-sigint:
-		// We received an interrupt signal, shut down.
-		log.Info("Received TERM signal, handling a graceful shutdown...")
+		log.Info("Received INT or TERM signal, handling a graceful shutdown...")
 
 		for name, server := range servers {
 			log.Infof("Shutting down %s server", name)