Add traceID if possible when using context logger. (#2518)

* Add traceID if possible when using context logger.

Signed-off-by: Cyril Tovena <[email protected]>

* Simplify userID extraction

Signed-off-by: Peter Štibraný <[email protected]>

* CHANGELOG.md

Signed-off-by: Peter Štibraný <[email protected]>

Co-authored-by: Peter Štibraný <[email protected]>

Author: cyriltovena

CHANGELOG.md

@@ -18,6 +18,7 @@
   * `cortex_querier_bucket_store_blocks_meta_sync_consistency_delay_seconds` > `cortex_querier_blocks_meta_sync_consistency_delay_seconds`
 * [CHANGE] Experimental TSDB: Modified default values for `compactor.deletion-delay` option from 48h to 12h and `-experimental.tsdb.bucket-store.ignore-deletion-marks-delay` from 24h to 6h. #2414
 * [CHANGE] Experimental WAL: Default value of `-ingester.checkpoint-enabled` changed to `true`. #2416
+* [CHANGE] `trace_id` field in log files has been renamed to `traceID`. #2518
 * [FEATURE] Ruler: The `-ruler.evaluation-delay` flag was added to allow users to configure a default evaluation delay for all rules in cortex. The default value is 0 which is the current behavior. #2423
 * [ENHANCEMENT] Experimental TSDB: sample ingestion errors are now reported via existing `cortex_discarded_samples_total` metric. #2370
 * [ENHANCEMENT] Failures on samples at distributors and ingesters return the first validation error as opposed to the last. #2383

pkg/util/log.go

@@ -103,10 +103,9 @@ func WithContext(ctx context.Context, l log.Logger) log.Logger {
 	// Weaveworks uses "orgs" and "orgID" to represent Cortex users,
 	// even though the code-base generally uses `userID` to refer to the same thing.
 	userID, err := user.ExtractOrgID(ctx)
-	if err != nil {
-		return l
+	if err == nil {
+		l = WithUserID(userID, l)
 	}
-	l = WithUserID(userID, l)
 
 	traceID, ok := middleware.ExtractTraceID(ctx)
 	if !ok {
@@ -127,7 +126,7 @@ func WithUserID(userID string, l log.Logger) log.Logger {
 // its details.
 func WithTraceID(traceID string, l log.Logger) log.Logger {
 	// See note in WithContext.
-	return log.With(l, "trace_id", traceID)
+	return log.With(l, "traceID", traceID)
 }
 
 // CheckFatal prints an error and exits with error code 1 if err is non-nil