Skip to content

Commit 11a62a9

Browse files
committed
Cortex should still send the request to upstream when Start == end
1 parent 42c68cd commit 11a62a9

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

pkg/querier/tripperware/queryrange/split_by_interval.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func splitQuery(r tripperware.Request, interval time.Duration) ([]tripperware.Re
7676
return nil, err
7777
}
7878
var reqs []tripperware.Request
79-
for start := r.GetStart(); start < r.GetEnd(); start = nextIntervalBoundary(start, r.GetStep(), interval) + r.GetStep() {
79+
for start := r.GetStart(); start <= r.GetEnd(); start = nextIntervalBoundary(start, r.GetStep(), interval) + r.GetStep() {
8080
end := nextIntervalBoundary(start, r.GetStep(), interval)
8181
if end+r.GetStep() >= r.GetEnd() {
8282
end = r.GetEnd()

pkg/querier/tripperware/queryrange/split_by_interval_test.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,23 @@ func TestSplitQuery(t *testing.T) {
8484
},
8585
interval: day,
8686
},
87+
{
88+
input: &PrometheusRequest{
89+
Start: 60 * 60 * seconds,
90+
End: 60 * 60 * seconds,
91+
Step: 15 * seconds,
92+
Query: "foo",
93+
},
94+
expected: []tripperware.Request{
95+
&PrometheusRequest{
96+
Start: 60 * 60 * seconds,
97+
End: 60 * 60 * seconds,
98+
Step: 15 * seconds,
99+
Query: "foo",
100+
},
101+
},
102+
interval: day,
103+
},
87104
{
88105
input: &PrometheusRequest{
89106
Start: 0,

0 commit comments

Comments
 (0)