Skip to content

Commit 2162e96

Browse files
committed
update changelog
Signed-off-by: Ben Ye <[email protected]>
1 parent 8e5d555 commit 2162e96

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
* [ENHANCEMENT] Store Gateway: add metric `cortex_bucket_store_chunk_refetches_total` for number of chunk refetches. #5532
6060
* [ENHANCEMENT] BasicLifeCycler: allow final-sleep during shutdown #5517
6161
* [ENHANCEMENT] All: Handling CMK Access Denied errors. #5420 #5542
62-
* [ENHANCEMENT] Querier: Retry store gateway chunk pool exhaustion error and client connection closing gRPC error. #5558
62+
* [ENHANCEMENT] Querier: Retry store gateway client connection closing gRPC error. #5558
6363
* [BUGFIX] Ruler: Validate if rule group can be safely converted back to rule group yaml from protobuf message #5265
6464
* [BUGFIX] Querier: Convert gRPC `ResourceExhausted` status code from store gateway to 422 limit error. #5286
6565
* [BUGFIX] Alertmanager: Route web-ui requests to the alertmanager distributor when sharding is enabled. #5293

pkg/querier/blocks_store_queryable.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,6 @@ func isRetryableError(err error) bool {
11201120
// https://github.com/grpc/grpc-go/blob/03172006f5d168fc646d87928d85cb9c4a480291/clientconn.go#L67
11211121
case codes.Canceled:
11221122
return strings.Contains(err.Error(), "grpc: the client connection is closing")
1123-
// TODO(yeya24): change Thanos to use ResourceExhausted for chunk pool error.
11241123
default:
11251124
return false
11261125
}

0 commit comments

Comments
 (0)