Skip to content

Commit 327792f

Browse files
committed
Send ddb region as awsCfg
1 parent d0db754 commit 327792f

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

pkg/ring/kv/dynamodb/dynamodb.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,12 @@ func newDynamodbKV(cfg Config, logger log.Logger) (dynamodbKV, error) {
5757
return dynamodbKV{}, err
5858
}
5959

60+
awsCfg := aws.NewConfig()
6061
if len(cfg.Region) > 0 {
61-
sess.Config = &aws.Config{
62-
Region: aws.String(cfg.Region),
63-
}
62+
awsCfg = awsCfg.WithRegion(cfg.Region)
6463
}
6564

66-
dynamoDB := dynamodb.New(sess)
65+
dynamoDB := dynamodb.New(sess, awsCfg)
6766

6867
ddbKV := &dynamodbKV{
6968
ddbClient: dynamoDB,

pkg/ring/kv/dynamodb/dynamodb_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ package dynamodb
33
import (
44
"context"
55
"fmt"
6+
util_log "github.com/cortexproject/cortex/pkg/util/log"
67
"strconv"
78
"testing"
89
"time"
@@ -28,6 +29,12 @@ func Test_TTLDisabled(t *testing.T) {
2829

2930
}
3031

32+
func Test_newDynamodbKV(t *testing.T) {
33+
_, err := newDynamodbKV(Config{Region: "us-west-2", TableName: "TEST"}, util_log.Logger)
34+
35+
require.NoError(t, err)
36+
}
37+
3138
func Test_TTL(t *testing.T) {
3239
ddbClientMock := &mockDynamodb{
3340
putItem: func(input *dynamodb.PutItemInput) *dynamodb.PutItemOutput {

0 commit comments

Comments
 (0)