Skip to content

Commit 50708c3

Browse files
committed
Do not export UserTSDB struct
Signed-off-by: Marco Pracucci <[email protected]>
1 parent 91d02a7 commit 50708c3

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

pkg/ingester/ingester_v2.go

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ type Shipper interface {
3838
Sync(ctx context.Context) (uploaded int, err error)
3939
}
4040

41-
// UserTSDB is a user's TSDB.
42-
type UserTSDB struct {
41+
type userTSDB struct {
4342
*tsdb.DB
4443

4544
// Thanos shipper used to ship blocks to the storage.
@@ -50,7 +49,7 @@ type UserTSDB struct {
5049

5150
// TSDBState holds data structures used by the TSDB storage engine
5251
type TSDBState struct {
53-
dbs map[string]*UserTSDB // tsdb sharded by userID
52+
dbs map[string]*userTSDB // tsdb sharded by userID
5453
bucket objstore.Bucket
5554

5655
// Keeps count of in-flight requests
@@ -79,7 +78,7 @@ func NewV2(cfg Config, clientConfig client.Config, limits *validation.Overrides,
7978
quit: make(chan struct{}),
8079
wal: &noopWAL{},
8180
TSDBState: TSDBState{
82-
dbs: make(map[string]*UserTSDB),
81+
dbs: make(map[string]*userTSDB),
8382
bucket: bucketClient,
8483
tsdbMetrics: newTSDBMetrics(registerer),
8584
},
@@ -391,7 +390,7 @@ func (i *Ingester) v2MetricsForLabelMatchers(ctx old_ctx.Context, req *client.Me
391390
return result, nil
392391
}
393392

394-
func (i *Ingester) getTSDB(userID string) *UserTSDB {
393+
func (i *Ingester) getTSDB(userID string) *userTSDB {
395394
i.userStatesMtx.RLock()
396395
defer i.userStatesMtx.RUnlock()
397396
db, _ := i.TSDBState.dbs[userID]
@@ -412,7 +411,7 @@ func (i *Ingester) getTSDBUsers() []string {
412411
return ids
413412
}
414413

415-
func (i *Ingester) getOrCreateTSDB(userID string, force bool) (*UserTSDB, error) {
414+
func (i *Ingester) getOrCreateTSDB(userID string, force bool) (*userTSDB, error) {
416415
db := i.getTSDB(userID)
417416
if db != nil {
418417
return db, nil
@@ -452,7 +451,7 @@ func (i *Ingester) getOrCreateTSDB(userID string, force bool) (*UserTSDB, error)
452451
}
453452

454453
// createTSDB creates a TSDB for a given userID, and returns the created db.
455-
func (i *Ingester) createTSDB(userID string) (*UserTSDB, error) {
454+
func (i *Ingester) createTSDB(userID string) (*userTSDB, error) {
456455
tsdbPromReg := prometheus.NewRegistry()
457456

458457
udir := i.cfg.TSDBConfig.BlocksDir(userID)
@@ -467,7 +466,7 @@ func (i *Ingester) createTSDB(userID string) (*UserTSDB, error) {
467466
return nil, err
468467
}
469468

470-
userDB := &UserTSDB{
469+
userDB := &userTSDB{
471470
DB: db,
472471
}
473472

@@ -507,7 +506,7 @@ func (i *Ingester) closeAllTSDB() {
507506
for userID, userDB := range i.TSDBState.dbs {
508507
userID := userID
509508

510-
go func(db *UserTSDB) {
509+
go func(db *userTSDB) {
511510
defer wg.Done()
512511

513512
if err := db.Close(); err != nil {

pkg/ingester/transfer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ func (i *Ingester) v2TransferOut(ctx context.Context) error {
545545
wg.Add(len(i.TSDBState.dbs))
546546

547547
for _, userDB := range i.TSDBState.dbs {
548-
go func(db *UserTSDB) {
548+
go func(db *userTSDB) {
549549
defer wg.Done()
550550
db.DisableCompactions()
551551
}(userDB)

pkg/ingester/transfer_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ import (
1818
"google.golang.org/grpc"
1919
)
2020

21-
type userTSDB struct {
21+
type testUserTSDB struct {
2222
userID string
2323
shipPercent int
2424
numBlocks int
2525
meta *shipper.Meta
2626
unshipped []string
2727
}
2828

29-
func createTSDB(t *testing.T, dir string, users []*userTSDB) {
29+
func createTSDB(t *testing.T, dir string, users []*testUserTSDB) {
3030
for _, user := range users {
3131

3232
os.MkdirAll(filepath.Join(dir, user.userID), 0777)
@@ -87,7 +87,7 @@ func TestUnshippedBlocks(t *testing.T) {
8787
One of them has all blocks shipped,
8888
One of them has no blocks shipped,
8989
*/
90-
users := []*userTSDB{
90+
users := []*testUserTSDB{
9191
{
9292
userID: "0",
9393
shipPercent: 70,
@@ -157,7 +157,7 @@ func TestTransferUser(t *testing.T) {
157157
dir, err := ioutil.TempDir("", "tsdb")
158158
require.NoError(t, err)
159159

160-
createTSDB(t, dir, []*userTSDB{
160+
createTSDB(t, dir, []*testUserTSDB{
161161
{
162162
userID: "0",
163163
shipPercent: 0,

0 commit comments

Comments
 (0)