Prevent counting 2xx responses as failed writes

rajagopalanand · rajagopalanand · commit 510ea18418c5 · 2025-06-03T18:28:29.000Z
diff --git a/pkg/ruler/compat.go b/pkg/ruler/compat.go
@@ -96,7 +96,7 @@ func (a *PusherAppender) Commit() error {
 	_, err := a.pusher.Push(user.InjectOrgID(a.ctx, a.userID), req)
 	if err != nil {
 		// Don't report errors that ended with 4xx HTTP status code (series limits, duplicate samples, out of order, etc.)
-		if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok || resp.Code/100 != 4 {
+		if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok || (resp.Code/100 != 2 && resp.Code/100 != 4) {
 			a.failedWrites.Inc()
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func (a *PusherAppender) Commit() error {`
`96`	`96`	`_, err := a.pusher.Push(user.InjectOrgID(a.ctx, a.userID), req)`
`97`	`97`	`if err != nil {`
`98`	`98`	`// Don't report errors that ended with 4xx HTTP status code (series limits, duplicate samples, out of order, etc.)`
`99`		`- if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok \|\| resp.Code/100 != 4 {`
	`99`	`+ if resp, ok := httpgrpc.HTTPResponseFromError(err); !ok \|\| (resp.Code/100 != 2 && resp.Code/100 != 4) {`
`100`	`100`	`a.failedWrites.Inc()`
`101`	`101`	`}`
`102`	`102`	`}`