Skip to content

Commit 51f7047

Browse files
jaybatra26pracucci
jaybatra26
and
pracucci
authored
Removes all the occurences of omitempty (#2209)
* Removes all the occurences of omitempty(#2209) This PR removes all the occurences of omitempty from structs. Signed-off by Jay Batra <[email protected]> Signed-off-by: Jay Batra <[email protected]> * Update CHANGELOG.md Co-authored-by: Marco Pracucci <[email protected]>
1 parent bf59f9f commit 51f7047

26 files changed

+130
-129
lines changed

‎CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* [ENHANCEMENT] Experimental TSDB: Add support for local `filesystem` backend. #2245
1515
* [ENHANCEMENT] Allow 1w (where w denotes week) and 1y (where y denotes year) when setting table period and retention. #2252
1616
* [ENHANCEMENT] Added FIFO cache metrics for current number of entries and memory usage. #2270
17+
* [ENHANCEMENT] Output all config fields to /config API, including those with empty value. #2209
1718
* [BUGFIX] Fixed etcd client keepalive settings. #2278
1819
* [BUGFIX] Fixed bug in updating last element of FIFO cache. #2270
1920

@@ -405,4 +406,4 @@ This release has several exciting features, the most notable of them being setti
405406
* `ha-tracker.cluster` is now `distributor.ha-tracker.cluster`
406407
* [FEATURE] You can specify "heap ballast" to reduce Go GC Churn #1489
407408
* [BUGFIX] HA Tracker no longer always makes a request to Consul/Etcd when a request is not from the active replica #1516
408-
* [BUGFIX] Queries are now correctly cancelled by the query-frontend #1508
409+
* [BUGFIX] Queries are now correctly cancelled by the query-frontend #1508

‎pkg/chunk/cache/background.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ var (
2626

2727
// BackgroundConfig is config for a Background Cache.
2828
type BackgroundConfig struct {
29-
WriteBackGoroutines int `yaml:"writeback_goroutines,omitempty"`
30-
WriteBackBuffer int `yaml:"writeback_buffer,omitempty"`
29+
WriteBackGoroutines int `yaml:"writeback_goroutines"`
30+
WriteBackBuffer int `yaml:"writeback_buffer"`
3131
}
3232

3333
// RegisterFlagsWithPrefix adds the flags required to config this to the given FlagSet

‎pkg/chunk/cache/cache.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,18 +22,18 @@ type Cache interface {
2222

2323
// Config for building Caches.
2424
type Config struct {
25-
EnableFifoCache bool `yaml:"enable_fifocache,omitempty"`
25+
EnableFifoCache bool `yaml:"enable_fifocache"`
2626

27-
DefaultValidity time.Duration `yaml:"default_validity,omitempty"`
27+
DefaultValidity time.Duration `yaml:"default_validity"`
2828

29-
Background BackgroundConfig `yaml:"background,omitempty"`
30-
Memcache MemcachedConfig `yaml:"memcached,omitempty"`
31-
MemcacheClient MemcachedClientConfig `yaml:"memcached_client,omitempty"`
32-
Redis RedisConfig `yaml:"redis,omitempty"`
33-
Fifocache FifoCacheConfig `yaml:"fifocache,omitempty"`
29+
Background BackgroundConfig `yaml:"background"`
30+
Memcache MemcachedConfig `yaml:"memcached"`
31+
MemcacheClient MemcachedClientConfig `yaml:"memcached_client"`
32+
Redis RedisConfig `yaml:"redis"`
33+
Fifocache FifoCacheConfig `yaml:"fifocache"`
3434

3535
// This is to name the cache metrics properly.
36-
Prefix string `yaml:"prefix,omitempty" doc:"hidden"`
36+
Prefix string `yaml:"prefix" doc:"hidden"`
3737

3838
// For tests to inject specific implementations.
3939
Cache Cache `yaml:"-"`

‎pkg/chunk/cache/fifo_cache.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ var (
7171

7272
// FifoCacheConfig holds config for the FifoCache.
7373
type FifoCacheConfig struct {
74-
Size int `yaml:"size,omitempty"`
75-
Validity time.Duration `yaml:"validity,omitempty"`
74+
Size int `yaml:"size"`
75+
Validity time.Duration `yaml:"validity"`
7676
}
7777

7878
// RegisterFlagsWithPrefix adds the flags required to config this to the given FlagSet

‎pkg/chunk/cache/memcached.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ func (o observableVecCollector) After(method, statusCode string, start time.Time
4141

4242
// MemcachedConfig is config to make a Memcached
4343
type MemcachedConfig struct {
44-
Expiration time.Duration `yaml:"expiration,omitempty"`
44+
Expiration time.Duration `yaml:"expiration"`
4545

46-
BatchSize int `yaml:"batch_size,omitempty"`
47-
Parallelism int `yaml:"parallelism,omitempty"`
46+
BatchSize int `yaml:"batch_size"`
47+
Parallelism int `yaml:"parallelism"`
4848
}
4949

5050
// RegisterFlagsWithPrefix adds the flags required to config this to the given FlagSet

‎pkg/chunk/cache/memcached_client.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,12 +39,12 @@ type memcachedClient struct {
3939

4040
// MemcachedClientConfig defines how a MemcachedClient should be constructed.
4141
type MemcachedClientConfig struct {
42-
Host string `yaml:"host,omitempty"`
43-
Service string `yaml:"service,omitempty"`
44-
Timeout time.Duration `yaml:"timeout,omitempty"`
45-
MaxIdleConns int `yaml:"max_idle_conns,omitempty"`
46-
UpdateInterval time.Duration `yaml:"update_interval,omitempty"`
47-
ConsistentHash bool `yaml:"consistent_hash,omitempty"`
42+
Host string `yaml:"host"`
43+
Service string `yaml:"service"`
44+
Timeout time.Duration `yaml:"timeout"`
45+
MaxIdleConns int `yaml:"max_idle_conns"`
46+
UpdateInterval time.Duration `yaml:"update_interval"`
47+
ConsistentHash bool `yaml:"consistent_hash"`
4848
}
4949

5050
// RegisterFlagsWithPrefix adds the flags required to config this to the given FlagSet

‎pkg/chunk/cache/redis_cache.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ type RedisCache struct {
2222

2323
// RedisConfig defines how a RedisCache should be constructed.
2424
type RedisConfig struct {
25-
Endpoint string `yaml:"endpoint,omitempty"`
26-
Timeout time.Duration `yaml:"timeout,omitempty"`
27-
Expiration time.Duration `yaml:"expiration,omitempty"`
28-
MaxIdleConns int `yaml:"max_idle_conns,omitempty"`
29-
MaxActiveConns int `yaml:"max_active_conns,omitempty"`
25+
Endpoint string `yaml:"endpoint"`
26+
Timeout time.Duration `yaml:"timeout"`
27+
Expiration time.Duration `yaml:"expiration"`
28+
MaxIdleConns int `yaml:"max_idle_conns"`
29+
MaxActiveConns int `yaml:"max_active_conns"`
3030
Password flagext.Secret `yaml:"password"`
3131
EnableTLS bool `yaml:"enable_tls"`
3232
}

‎pkg/chunk/cassandra/storage_client.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,22 @@ import (
1919

2020
// Config for a StorageClient
2121
type Config struct {
22-
Addresses string `yaml:"addresses,omitempty"`
23-
Port int `yaml:"port,omitempty"`
24-
Keyspace string `yaml:"keyspace,omitempty"`
25-
Consistency string `yaml:"consistency,omitempty"`
26-
ReplicationFactor int `yaml:"replication_factor,omitempty"`
27-
DisableInitialHostLookup bool `yaml:"disable_initial_host_lookup,omitempty"`
28-
SSL bool `yaml:"SSL,omitempty"`
29-
HostVerification bool `yaml:"host_verification,omitempty"`
30-
CAPath string `yaml:"CA_path,omitempty"`
31-
Auth bool `yaml:"auth,omitempty"`
32-
Username string `yaml:"username,omitempty"`
33-
Password flagext.Secret `yaml:"password,omitempty"`
34-
PasswordFile string `yaml:"password_file,omitempty"`
22+
Addresses string `yaml:"addresses"`
23+
Port int `yaml:"port"`
24+
Keyspace string `yaml:"keyspace"`
25+
Consistency string `yaml:"consistency"`
26+
ReplicationFactor int `yaml:"replication_factor"`
27+
DisableInitialHostLookup bool `yaml:"disable_initial_host_lookup"`
28+
SSL bool `yaml:"SSL"`
29+
HostVerification bool `yaml:"host_verification"`
30+
CAPath string `yaml:"CA_path"`
31+
Auth bool `yaml:"auth"`
32+
Username string `yaml:"username"`
33+
Password flagext.Secret `yaml:"password"`
34+
PasswordFile string `yaml:"password_file"`
3535
CustomAuthenticators flagext.StringSlice `yaml:"custom_authenticators"`
36-
Timeout time.Duration `yaml:"timeout,omitempty"`
37-
ConnectTimeout time.Duration `yaml:"connect_timeout,omitempty"`
36+
Timeout time.Duration `yaml:"timeout"`
37+
ConnectTimeout time.Duration `yaml:"connect_timeout"`
3838
Retries int `yaml:"max_retries"`
3939
MaxBackoff time.Duration `yaml:"retry_max_backoff"`
4040
MinBackoff time.Duration `yaml:"retry_min_backoff"`

‎pkg/chunk/chunk_store.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ var (
4747

4848
// StoreConfig specifies config for a ChunkStore
4949
type StoreConfig struct {
50-
ChunkCacheConfig cache.Config `yaml:"chunk_cache_config,omitempty"`
51-
WriteDedupeCacheConfig cache.Config `yaml:"write_dedupe_cache_config,omitempty"`
50+
ChunkCacheConfig cache.Config `yaml:"chunk_cache_config"`
51+
WriteDedupeCacheConfig cache.Config `yaml:"write_dedupe_cache_config"`
5252

53-
CacheLookupsOlderThan time.Duration `yaml:"cache_lookups_older_than,omitempty"`
53+
CacheLookupsOlderThan time.Duration `yaml:"cache_lookups_older_than"`
5454

5555
// Limits query start time to be greater than now() - MaxLookBackPeriod, if set.
5656
MaxLookBackPeriod time.Duration `yaml:"max_look_back_period"`

‎pkg/chunk/schema_config.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ type PeriodConfig struct {
3636
ObjectType string `yaml:"object_store"` // type of object client to use; if omitted, defaults to store.
3737
Schema string `yaml:"schema"`
3838
IndexTables PeriodicTableConfig `yaml:"index"`
39-
ChunkTables PeriodicTableConfig `yaml:"chunks,omitempty"`
39+
ChunkTables PeriodicTableConfig `yaml:"chunks"`
4040
RowShards uint32 `yaml:"row_shards"`
4141
}
4242

@@ -330,13 +330,13 @@ func (cfg PeriodicTableConfig) MarshalYAML() (interface{}, error) {
330330

331331
// AutoScalingConfig for DynamoDB tables.
332332
type AutoScalingConfig struct {
333-
Enabled bool `yaml:"enabled,omitempty"`
334-
RoleARN string `yaml:"role_arn,omitempty"`
335-
MinCapacity int64 `yaml:"min_capacity,omitempty"`
336-
MaxCapacity int64 `yaml:"max_capacity,omitempty"`
337-
OutCooldown int64 `yaml:"out_cooldown,omitempty"`
338-
InCooldown int64 `yaml:"in_cooldown,omitempty"`
339-
TargetValue float64 `yaml:"target,omitempty"`
333+
Enabled bool `yaml:"enabled"`
334+
RoleARN string `yaml:"role_arn"`
335+
MinCapacity int64 `yaml:"min_capacity"`
336+
MaxCapacity int64 `yaml:"max_capacity"`
337+
OutCooldown int64 `yaml:"out_cooldown"`
338+
InCooldown int64 `yaml:"in_cooldown"`
339+
TargetValue float64 `yaml:"target"`
340340
}
341341

342342
// RegisterFlags adds the flags required to config this to the given FlagSet.

‎pkg/chunk/storage/factory.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,9 @@ type Config struct {
6161

6262
IndexCacheValidity time.Duration
6363

64-
IndexQueriesCacheConfig cache.Config `yaml:"index_queries_cache_config,omitempty"`
64+
IndexQueriesCacheConfig cache.Config `yaml:"index_queries_cache_config"`
6565

66-
DeleteStoreConfig purger.DeleteStoreConfig `yaml:"delete_store,omitempty"`
66+
DeleteStoreConfig purger.DeleteStoreConfig `yaml:"delete_store"`
6767
}
6868

6969
// RegisterFlags adds the flags required to configure this flag set.

‎pkg/compactor/compactor_ring.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ import (
1818
// is used to strip down the config to the minimum, and avoid confusion
1919
// to the user.
2020
type RingConfig struct {
21-
KVStore kv.Config `yaml:"kvstore,omitempty"`
22-
HeartbeatPeriod time.Duration `yaml:"heartbeat_period,omitempty"`
23-
HeartbeatTimeout time.Duration `yaml:"heartbeat_timeout,omitempty"`
21+
KVStore kv.Config `yaml:"kvstore"`
22+
HeartbeatPeriod time.Duration `yaml:"heartbeat_period"`
23+
HeartbeatTimeout time.Duration `yaml:"heartbeat_timeout"`
2424

2525
// Instance details
2626
InstanceID string `yaml:"instance_id" doc:"hidden"`

‎pkg/cortex/cortex.go

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -65,35 +65,35 @@ import (
6565

6666
// Config is the root config for Cortex.
6767
type Config struct {
68-
Target moduleName `yaml:"target,omitempty"`
69-
AuthEnabled bool `yaml:"auth_enabled,omitempty"`
68+
Target moduleName `yaml:"target"`
69+
AuthEnabled bool `yaml:"auth_enabled"`
7070
PrintConfig bool `yaml:"-"`
7171
HTTPPrefix string `yaml:"http_prefix"`
7272

73-
Server server.Config `yaml:"server,omitempty"`
74-
Distributor distributor.Config `yaml:"distributor,omitempty"`
75-
Querier querier.Config `yaml:"querier,omitempty"`
76-
IngesterClient client.Config `yaml:"ingester_client,omitempty"`
77-
Ingester ingester.Config `yaml:"ingester,omitempty"`
78-
Flusher flusher.Config `yaml:"flusher,omitempty"`
79-
Storage storage.Config `yaml:"storage,omitempty"`
80-
ChunkStore chunk.StoreConfig `yaml:"chunk_store,omitempty"`
81-
Schema chunk.SchemaConfig `yaml:"schema,omitempty" doc:"hidden"` // Doc generation tool doesn't support it because part of the SchemaConfig doesn't support CLI flags (needs manual documentation)
82-
LimitsConfig validation.Limits `yaml:"limits,omitempty"`
83-
Prealloc client.PreallocConfig `yaml:"prealloc,omitempty" doc:"hidden"`
84-
Worker frontend.WorkerConfig `yaml:"frontend_worker,omitempty"`
85-
Frontend frontend.Config `yaml:"frontend,omitempty"`
86-
QueryRange queryrange.Config `yaml:"query_range,omitempty"`
87-
TableManager chunk.TableManagerConfig `yaml:"table_manager,omitempty"`
73+
Server server.Config `yaml:"server"`
74+
Distributor distributor.Config `yaml:"distributor"`
75+
Querier querier.Config `yaml:"querier"`
76+
IngesterClient client.Config `yaml:"ingester_client"`
77+
Ingester ingester.Config `yaml:"ingester"`
78+
Flusher flusher.Config `yaml:"flusher"`
79+
Storage storage.Config `yaml:"storage"`
80+
ChunkStore chunk.StoreConfig `yaml:"chunk_store"`
81+
Schema chunk.SchemaConfig `yaml:"schema" doc:"hidden"` // Doc generation tool doesn't support it because part of the SchemaConfig doesn't support CLI flags (needs manual documentation)
82+
LimitsConfig validation.Limits `yaml:"limits"`
83+
Prealloc client.PreallocConfig `yaml:"prealloc" doc:"hidden"`
84+
Worker frontend.WorkerConfig `yaml:"frontend_worker"`
85+
Frontend frontend.Config `yaml:"frontend"`
86+
QueryRange queryrange.Config `yaml:"query_range"`
87+
TableManager chunk.TableManagerConfig `yaml:"table_manager"`
8888
Encoding encoding.Config `yaml:"-"` // No yaml for this, it only works with flags.
8989
TSDB tsdb.Config `yaml:"tsdb"`
90-
Compactor compactor.Config `yaml:"compactor,omitempty"`
91-
DataPurgerConfig purger.Config `yaml:"purger,omitempty"`
90+
Compactor compactor.Config `yaml:"compactor"`
91+
DataPurgerConfig purger.Config `yaml:"purger"`
9292

93-
Ruler ruler.Config `yaml:"ruler,omitempty"`
94-
Configs configs.Config `yaml:"configs,omitempty"`
95-
Alertmanager alertmanager.MultitenantAlertmanagerConfig `yaml:"alertmanager,omitempty"`
96-
RuntimeConfig runtimeconfig.ManagerConfig `yaml:"runtime_config,omitempty"`
93+
Ruler ruler.Config `yaml:"ruler"`
94+
Configs configs.Config `yaml:"configs"`
95+
Alertmanager alertmanager.MultitenantAlertmanagerConfig `yaml:"alertmanager"`
96+
RuntimeConfig runtimeconfig.ManagerConfig `yaml:"runtime_config"`
9797
MemberlistKV memberlist.KVConfig `yaml:"memberlist"`
9898
}
9999

‎pkg/distributor/distributor.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,18 +120,18 @@ type Distributor struct {
120120
// Config contains the configuration require to
121121
// create a Distributor
122122
type Config struct {
123-
PoolConfig ingester_client.PoolConfig `yaml:"pool,omitempty"`
123+
PoolConfig ingester_client.PoolConfig `yaml:"pool"`
124124

125-
HATrackerConfig HATrackerConfig `yaml:"ha_tracker,omitempty"`
125+
HATrackerConfig HATrackerConfig `yaml:"ha_tracker"`
126126

127127
MaxRecvMsgSize int `yaml:"max_recv_msg_size"`
128-
RemoteTimeout time.Duration `yaml:"remote_timeout,omitempty"`
129-
ExtraQueryDelay time.Duration `yaml:"extra_queue_delay,omitempty"`
128+
RemoteTimeout time.Duration `yaml:"remote_timeout"`
129+
ExtraQueryDelay time.Duration `yaml:"extra_queue_delay"`
130130

131-
ShardByAllLabels bool `yaml:"shard_by_all_labels,omitempty"`
131+
ShardByAllLabels bool `yaml:"shard_by_all_labels"`
132132

133133
// Distributors ring
134-
DistributorRing RingConfig `yaml:"ring,omitempty"`
134+
DistributorRing RingConfig `yaml:"ring"`
135135

136136
// for testing
137137
ingesterClientFactory client.Factory `yaml:"-"`

‎pkg/distributor/distributor_ring.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ import (
1818
// is used to strip down the config to the minimum, and avoid confusion
1919
// to the user.
2020
type RingConfig struct {
21-
KVStore kv.Config `yaml:"kvstore,omitempty"`
22-
HeartbeatPeriod time.Duration `yaml:"heartbeat_period,omitempty"`
23-
HeartbeatTimeout time.Duration `yaml:"heartbeat_timeout,omitempty"`
21+
KVStore kv.Config `yaml:"kvstore"`
22+
HeartbeatPeriod time.Duration `yaml:"heartbeat_period"`
23+
HeartbeatTimeout time.Duration `yaml:"heartbeat_timeout"`
2424

2525
// Instance details
2626
InstanceID string `yaml:"instance_id" doc:"hidden"`

‎pkg/distributor/ha_tracker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ type haTracker struct {
8282
// HATrackerConfig contains the configuration require to
8383
// create a HA Tracker.
8484
type HATrackerConfig struct {
85-
EnableHATracker bool `yaml:"enable_ha_tracker,omitempty"`
85+
EnableHATracker bool `yaml:"enable_ha_tracker"`
8686
// We should only update the timestamp if the difference
8787
// between the stored timestamp and the time we received a sample at
8888
// is more than this duration.

‎pkg/flusher/flusher.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ import (
1717

1818
// Config for an Ingester.
1919
type Config struct {
20-
WALDir string `yaml:"wal_dir,omitempty"`
21-
ConcurrentFlushes int `yaml:"concurrent_flushes,omitempty"`
22-
FlushOpTimeout time.Duration `yaml:"flush_op_timeout,omitempty"`
20+
WALDir string `yaml:"wal_dir"`
21+
ConcurrentFlushes int `yaml:"concurrent_flushes"`
22+
FlushOpTimeout time.Duration `yaml:"flush_op_timeout"`
2323
}
2424

2525
// RegisterFlags adds the flags required to config this to the given FlagSet

‎pkg/ingester/client/pool.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ type Factory func(addr string) (grpc_health_v1.HealthClient, error)
3131

3232
// PoolConfig is config for creating a Pool.
3333
type PoolConfig struct {
34-
ClientCleanupPeriod time.Duration `yaml:"client_cleanup_period,omitempty"`
35-
HealthCheckIngesters bool `yaml:"health_check_ingesters,omitempty"`
34+
ClientCleanupPeriod time.Duration `yaml:"client_cleanup_period"`
35+
HealthCheckIngesters bool `yaml:"health_check_ingesters"`
3636
RemoteTimeout time.Duration `yaml:"-"`
3737
}
3838

‎pkg/ingester/ingester.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ var (
4141

4242
// Config for an Ingester.
4343
type Config struct {
44-
WALConfig WALConfig `yaml:"walconfig,omitempty"`
45-
LifecyclerConfig ring.LifecyclerConfig `yaml:"lifecycler,omitempty"`
44+
WALConfig WALConfig `yaml:"walconfig"`
45+
LifecyclerConfig ring.LifecyclerConfig `yaml:"lifecycler"`
4646

4747
// Config for transferring chunks. Zero or negative = no retries.
48-
MaxTransferRetries int `yaml:"max_transfer_retries,omitempty"`
48+
MaxTransferRetries int `yaml:"max_transfer_retries"`
4949

5050
// Config for chunk flushing.
5151
FlushCheckPeriod time.Duration

‎pkg/ingester/wal.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ import (
2929

3030
// WALConfig is config for the Write Ahead Log.
3131
type WALConfig struct {
32-
WALEnabled bool `yaml:"wal_enabled,omitempty"`
33-
CheckpointEnabled bool `yaml:"checkpoint_enabled,omitempty"`
34-
Recover bool `yaml:"recover_from_wal,omitempty"`
35-
Dir string `yaml:"wal_dir,omitempty"`
36-
CheckpointDuration time.Duration `yaml:"checkpoint_duration,omitempty"`
32+
WALEnabled bool `yaml:"wal_enabled"`
33+
CheckpointEnabled bool `yaml:"checkpoint_enabled"`
34+
Recover bool `yaml:"recover_from_wal"`
35+
Dir string `yaml:"wal_dir"`
36+
CheckpointDuration time.Duration `yaml:"checkpoint_duration"`
3737
metricsRegisterer prometheus.Registerer `yaml:"-"`
3838
}
3939

0 commit comments

Comments
 (0)