Bug fix: ingesters returning empty response

Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>

Author: harry671003

CHANGELOG.md

@@ -23,6 +23,7 @@
 * [BUGFIX] Fix panic when otel and xray tracing is enabled. #5044
 * [BUGFIX] Fixed no compact block got grouped in shuffle sharding grouper. #5055
 * [BUGFIX] Tracing: Fix missing object storage span instrumentation. #5074
+* [BUGFIX] Ingester: Ingesters returning empty response for metadata APIs. #5081
 
 ## 1.14.0 2022-12-02
 

pkg/ingester/ingester.go

@@ -2572,7 +2572,7 @@ func metadataQueryRange(queryStart, queryEnd int64, db *userTSDB, queryStoreForL
 	if queryIngestersWithin > 0 && queryStoreForLabels {
 		// If the feature for querying metadata from store-gateway is enabled,
 		// then we don't want to manipulate the mint and maxt.
-		return
+		return queryStart, queryEnd, nil
 	}
 
 	// Ingesters are run with limited retention and we don't support querying the store-gateway for labels yet.

pkg/ingester/ingester_test.go

@@ -1797,14 +1797,16 @@ func Test_Ingester_MetricsForLabelMatchers(t *testing.T) {
 			},
 		},
 		"should filter metrics by time range if queryStoreForLabels and queryIngestersWithin is enabled": {
-			from: 100,
-			to:   1000,
+			from: 99999,
+			to:   100001,
 			matchers: []*client.LabelMatchers{{
 				Matchers: []*client.LabelMatcher{
 					{Type: client.EQUAL, Name: model.MetricNameLabel, Value: "test_1"},
 				},
 			}},
-			expected:             []*cortexpb.Metric{},
+			expected: []*cortexpb.Metric{
+				{Labels: cortexpb.FromLabelsToLabelAdapters(fixtures[0].lbls)},
+			},
 			queryStoreForLabels:  true,
 			queryIngestersWithin: time.Hour,
 		},