Skip to content

Commit 72ca7e4

Browse files
author
Thor
committed
s3insecure flag
Signed-off-by: Thor <[email protected]>
1 parent 26cefd9 commit 72ca7e4

File tree

3 files changed

+4
-0
lines changed

3 files changed

+4
-0
lines changed

pkg/cortex/modules.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ func (t *Cortex) initQuerier(cfg *Config) (err error) {
201201
Endpoint: cfg.Ingester.V2.S3Endpoint,
202202
AccessKey: cfg.Ingester.V2.S3Key,
203203
SecretKey: cfg.Ingester.V2.S3Secret,
204+
Insecure: cfg.Ingester.V2.S3Insecure,
204205
}
205206
store, err = querier.NewBlockQuerier(s3cfg, prometheus.DefaultRegisterer)
206207
if err != nil {

pkg/ingester/ingester.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
151151
f.StringVar(&cfg.V2.S3Secret, "ingester.v2.secret", "", "s3 secret")
152152
f.StringVar(&cfg.V2.S3Bucket, "ingester.v2.bucket", "", "s3 bucket")
153153
f.StringVar(&cfg.V2.S3Endpoint, "ingester.v2.endpoint", "", "s3 endpoint")
154+
f.BoolVar(&cfg.V2.S3Insecure, "ingester.v2.s3insecure", false, "use http for s3 endpoints")
154155
f.DurationVar(&cfg.V2.ShipInterval, "ingester.v2.shipinterval", 30*time.Second, "the frequency at which tsdb blocks are scanned for shipping")
155156
}
156157

pkg/ingester/ingester_v2.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ type V2Config struct {
3737
S3Bucket string
3838
S3Secret string
3939
S3Key string
40+
S3Insecure bool // useful for test clusters without https
4041
}
4142

4243
// NewV2 returns a new Ingester that uses prometheus block storage instead of chunk storage
@@ -48,6 +49,7 @@ func NewV2(cfg Config, clientConfig client.Config, limits *validation.Overrides,
4849
Endpoint: cfg.V2.S3Endpoint,
4950
AccessKey: cfg.V2.S3Key,
5051
SecretKey: cfg.V2.S3Secret,
52+
Insecure: cfg.V2.S3Insecure,
5153
}
5254
var err error
5355
bkt, err = s3.NewBucketWithConfig(util.Logger, s3Cfg, "cortex")

0 commit comments

Comments
 (0)