Skip to content

Commit 883bc59

Browse files
committed
log grafana headers along with query request before query execution
Signed-off-by: Ben Ye <[email protected]>
1 parent 0c1cb3d commit 883bc59

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

pkg/frontend/transport/handler.go

+18-7
Original file line numberDiff line numberDiff line change
@@ -228,13 +228,7 @@ func (f *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
228228
// Log request
229229
if f.cfg.QueryStatsEnabled {
230230
queryString = f.parseRequestQueryString(r, buf)
231-
logMessage := append([]interface{}{
232-
"msg", "query request",
233-
"component", "query-frontend",
234-
"method", r.Method,
235-
"path", r.URL.Path,
236-
}, formatQueryString(queryString)...)
237-
level.Info(util_log.WithContext(r.Context(), f.log)).Log(logMessage...)
231+
f.logQueryRequest(r, queryString)
238232
}
239233

240234
startTime := time.Now()
@@ -306,6 +300,23 @@ func formatGrafanaStatsFields(r *http.Request) []interface{} {
306300
return fields
307301
}
308302

303+
// logQueryRequest logs query request before query execution.
304+
func (f *Handler) logQueryRequest(r *http.Request, queryString url.Values) {
305+
logMessage := []interface{}{
306+
"msg", "query request",
307+
"component", "query-frontend",
308+
"method", r.Method,
309+
"path", r.URL.Path,
310+
}
311+
grafanaFields := formatGrafanaStatsFields(r)
312+
if len(grafanaFields) > 0 {
313+
logMessage = append(logMessage, grafanaFields...)
314+
}
315+
logMessage = append(logMessage, formatQueryString(queryString)...)
316+
317+
level.Info(util_log.WithContext(r.Context(), f.log)).Log(logMessage...)
318+
}
319+
309320
// reportSlowQuery reports slow queries.
310321
func (f *Handler) reportSlowQuery(r *http.Request, queryString url.Values, queryResponseTime time.Duration) {
311322
logMessage := []interface{}{

0 commit comments

Comments
 (0)