Fix missing return after writing sharding error (#3897)

nickbp · web-flow · commit 9c46081e1380 · 2021-03-03T08:19:49.000+01:00
At the moment the error ends up getting overwritten/obscured by the `This should not happen` error handling.

Signed-off-by: Nick Parker &lt;nick@nickbp.com&gt;
diff --git a/pkg/alertmanager/distributor.go b/pkg/alertmanager/distributor.go
@@ -143,6 +143,7 @@ func (d *Distributor) doWrite(userID string, w http.ResponseWriter, r *http.Requ
 
 	if err != nil {
 		respondFromError(err, w, logger)
+		return
 	}
 
 	firstSuccessfulResponseMtx.Lock() // Another request might be ongoing after quorum.

Original file line number	Diff line number	Diff line change
`@@ -143,6 +143,7 @@ func (d Distributor) doWrite(userID string, w http.ResponseWriter, r http.Requ`
`143`	`143`
`144`	`144`	`if err != nil {`
`145`	`145`	`respondFromError(err, w, logger)`
	`146`	`+ return`
`146`	`147`	`}`
`147`	`148`
`148`	`149`	`firstSuccessfulResponseMtx.Lock() // Another request might be ongoing after quorum.`