fix: split interval function should return 4xx

Signed-off-by: Ahmed Hassan <[email protected]>

Author: afhassan

pkg/querier/tripperware/queryrange/split_by_interval.go

@@ -54,7 +54,7 @@ func (s splitByInterval) Do(ctx context.Context, r tripperware.Request) (tripper
 	// to line up the boundaries with step.
 	interval, err := s.interval(ctx, r)
 	if err != nil {
-		return nil, httpgrpc.Errorf(http.StatusInternalServerError, err.Error())
+		return nil, httpgrpc.Errorf(http.StatusBadRequest, err.Error())
 	}
 	reqs, err := splitQuery(r, interval)
 	if err != nil {
@@ -153,11 +153,38 @@ func nextIntervalBoundary(t, step int64, interval time.Duration) int64 {
 
 // Returns a fixed split interval
 func staticIntervalFn(cfg Config) func(ctx context.Context, r tripperware.Request) (time.Duration, error) {
-	return func(_ context.Context, _ tripperware.Request) (time.Duration, error) {
+	return func(_ context.Context, r tripperware.Request) (time.Duration, error) {
+		totalRange, err := getTotalRangeFromRequest(r)
+		if err != nil {
+			return cfg.SplitQueriesByInterval, err
+		}
+		// Hardcode 7 day here, assuming SplitQueriesByInterval is configured as 1 day.
+		if totalRange > 7*cfg.SplitQueriesByInterval {
+			return 7 * cfg.SplitQueriesByInterval, nil
+		}
 		return cfg.SplitQueriesByInterval, nil
 	}
 }
 
+// getTotalRangeFromRequest gets MatrixSelector and SubqueryExpr range sum from the query.
+func getTotalRangeFromRequest(r tripperware.Request) (time.Duration, error) {
+	expr, err := parser.ParseExpr(r.GetQuery())
+	if err != nil {
+		return 0, err
+	}
+	totalRange := time.Duration(0)
+	parser.Inspect(expr, func(node parser.Node, path []parser.Node) error {
+		switch n := node.(type) {
+		case *parser.MatrixSelector:
+			totalRange += n.Range
+		case *parser.SubqueryExpr:
+			totalRange += n.Range
+		}
+		return nil
+	})
+	return totalRange, nil
+}
+
 // Returns a dynamic multiple of base interval adjusted depending on configured 'max_shards_per_query' and 'max_fetched_data_duration_per_query'
 func dynamicIntervalFn(cfg Config, limits tripperware.Limits, queryAnalyzer querysharding.Analyzer, lookbackDelta time.Duration) func(ctx context.Context, r tripperware.Request) (time.Duration, error) {
 	return func(ctx context.Context, r tripperware.Request) (time.Duration, error) {