added test cases

Signed-off-by: Shashank <[email protected]>

Author: moki1202

pkg/storegateway/sharding_strategy.go

@@ -71,15 +71,17 @@ func NewDefaultShardingStrategy(r *ring.Ring, instanceAddr string, logger log.Lo
 
 // FilterUsers implements ShardingStrategy.
 func (s *DefaultShardingStrategy) FilterUsers(_ context.Context, userIDs []string) []string {
-	allUserIDs := userIDs
-
+	filteredUserIDs := []string{} 
 	for _, userID := range userIDs {
 		if !s.allowedTenants.IsAllowed(userID) {
 			level.Debug(s.logger).Log("msg", "ignoring storage gateway for user, not allowed", "user", userID)
+			continue
 		}
+
+		filteredUserIDs = append(filteredUserIDs, userID)
 	}
 
-	return allUserIDs
+	return filteredUserIDs
 }
 
 // FilterBlocks implements ShardingStrategy.

pkg/storegateway/sharding_strategy_test.go

@@ -42,6 +42,9 @@ func TestDefaultShardingStrategy(t *testing.T) {
 		zoneAwarenessEnabled bool
 		setupRing            func(*ring.Desc)
 		expectedBlocks       map[string][]ulid.ULID
+		enableTenants        []string
+		disableTenants       []string
+		allowedTenants	func(*DefaultShardingStrategy)
 	}{
 		"one ACTIVE instance in the ring with replication factor = 1": {
 			replicationFactor: 1,
@@ -64,6 +67,21 @@ func TestDefaultShardingStrategy(t *testing.T) {
 				"127.0.0.2": {block2, block4},
 			},
 		},
+		"two ACTIVE instances in the ring with replication factor = 1 and one tenant disabled": {
+			replicationFactor: 1,
+			setupRing: func(r *ring.Desc) {
+				r.AddIngester("instance-1", "127.0.0.1", "", []uint32{block1Hash + 1, block3Hash + 1}, ring.ACTIVE, registeredAt)
+				r.AddIngester("instance-2", "127.0.0.2", "", []uint32{block2Hash + 1, block4Hash + 1}, ring.ACTIVE, registeredAt)
+		},
+			allowedTenants: func(r *DefaultShardingStrategy) {
+						 enableTenants:  []string{"u-1"}
+				r.FilterUsers(context.Background(), enableTenants)
+			},
+			expectedBlocks: map[string][]ulid.ULID{
+				"127.0.0.1": {block1, block3}, // Tenant 1 blocks expected
+				"127.0.0.2": {},               // Tenant 2 blocks disabled
+			},
+	},
 		"one ACTIVE instance in the ring with replication factor = 2": {
 			replicationFactor: 2,
 			setupRing: func(r *ring.Desc) {