Skip to content

Commit b6b6d5f

Browse files
committed
don't mark two flags as deprecated
Signed-off-by: Ben Ye <[email protected]>
1 parent 10ccb6d commit b6b6d5f

File tree

5 files changed

+6
-30
lines changed

5 files changed

+6
-30
lines changed

docs/blocks-storage/querier.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -889,8 +889,6 @@ blocks_storage:
889889
# CLI flag: -blocks-storage.tsdb.memory-snapshot-on-shutdown
890890
[memory_snapshot_on_shutdown: <boolean> | default = false]
891891
892-
# [EXPERIMENTAL] Configures the maximum capacity for out-of-order chunks (in
893-
# samples). If set to <=0, default value 32 is assumed.
894892
# [EXPERIMENTAL] Configures the maximum number of samples per chunk that can
895893
# be out-of-order.
896894
# CLI flag: -blocks-storage.tsdb.out-of-order-cap-max

docs/blocks-storage/store-gateway.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -952,8 +952,6 @@ blocks_storage:
952952
# CLI flag: -blocks-storage.tsdb.memory-snapshot-on-shutdown
953953
[memory_snapshot_on_shutdown: <boolean> | default = false]
954954
955-
# [EXPERIMENTAL] Configures the maximum capacity for out-of-order chunks (in
956-
# samples). If set to <=0, default value 32 is assumed.
957955
# [EXPERIMENTAL] Configures the maximum number of samples per chunk that can
958956
# be out-of-order.
959957
# CLI flag: -blocks-storage.tsdb.out-of-order-cap-max

docs/configuration/config-file-reference.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2589,13 +2589,11 @@ The `limits_config` configures default and per-tenant limits imposed by Cortex s
25892589
# CLI flag: -validation.max-metadata-length
25902590
[max_metadata_length: <int> | default = 1024]
25912591
2592-
# Deprecated (use ingester.out-of-order-time-window instead): Reject old
2593-
# samples.
2592+
# Reject old samples.
25942593
# CLI flag: -validation.reject-old-samples
25952594
[reject_old_samples: <boolean> | default = false]
25962595
2597-
# Deprecated (use ingester.out-of-order-time-window instead): Maximum accepted
2598-
# sample age before rejecting.
2596+
# Maximum accepted sample age before rejecting.
25992597
# CLI flag: -validation.reject-old-samples.max-age
26002598
[reject_old_samples_max_age: <duration> | default = 2w]
26012599
@@ -3738,8 +3736,6 @@ tsdb:
37383736
# CLI flag: -blocks-storage.tsdb.memory-snapshot-on-shutdown
37393737
[memory_snapshot_on_shutdown: <boolean> | default = false]
37403738
3741-
# [EXPERIMENTAL] Configures the maximum capacity for out-of-order chunks (in
3742-
# samples). If set to <=0, default value 32 is assumed.
37433739
# [EXPERIMENTAL] Configures the maximum number of samples per chunk that can
37443740
# be out-of-order.
37453741
# CLI flag: -blocks-storage.tsdb.out-of-order-cap-max

pkg/ingester/ingester.go

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1846,7 +1846,6 @@ func (i *Ingester) createTSDB(userID string) (*userTSDB, error) {
18461846
}
18471847
// Create a new user database
18481848
db, err := tsdb.Open(udir, userLogger, tsdbPromReg, &tsdb.Options{
1849-
<<<<<<< HEAD
18501849
RetentionDuration: i.cfg.BlocksStorageConfig.TSDB.Retention.Milliseconds(),
18511850
MinBlockDuration: blockRanges[0],
18521851
MaxBlockDuration: blockRanges[len(blockRanges)-1],
@@ -1862,23 +1861,8 @@ func (i *Ingester) createTSDB(userID string) (*userTSDB, error) {
18621861
MaxExemplars: int64(i.cfg.BlocksStorageConfig.TSDB.MaxExemplars),
18631862
HeadChunksWriteQueueSize: i.cfg.BlocksStorageConfig.TSDB.HeadChunksWriteQueueSize,
18641863
EnableMemorySnapshotOnShutdown: i.cfg.BlocksStorageConfig.TSDB.MemorySnapshotOnShutdown,
1865-
=======
1866-
RetentionDuration: i.cfg.BlocksStorageConfig.TSDB.Retention.Milliseconds(),
1867-
MinBlockDuration: blockRanges[0],
1868-
MaxBlockDuration: blockRanges[len(blockRanges)-1],
1869-
NoLockfile: true,
1870-
StripeSize: i.cfg.BlocksStorageConfig.TSDB.StripeSize,
1871-
HeadChunksWriteBufferSize: i.cfg.BlocksStorageConfig.TSDB.HeadChunksWriteBufferSize,
1872-
WALCompression: i.cfg.BlocksStorageConfig.TSDB.WALCompressionEnabled,
1873-
WALSegmentSize: i.cfg.BlocksStorageConfig.TSDB.WALSegmentSizeBytes,
1874-
SeriesLifecycleCallback: userDB,
1875-
BlocksToDelete: userDB.blocksToDelete,
1876-
EnableExemplarStorage: enableExemplars,
1877-
IsolationDisabled: true,
1878-
MaxExemplars: int64(i.cfg.BlocksStorageConfig.TSDB.MaxExemplars),
1879-
OutOfOrderTimeWindow: time.Duration(i.limits.OutOfOrderTimeWindow(userID)).Milliseconds(),
1880-
OutOfOrderCapMax: i.cfg.BlocksStorageConfig.TSDB.OutOfOrderCapMax,
1881-
>>>>>>> 75f817aec (support out of order samples ingestion feature)
1864+
OutOfOrderTimeWindow: time.Duration(i.limits.OutOfOrderTimeWindow(userID)).Milliseconds(),
1865+
OutOfOrderCapMax: i.cfg.BlocksStorageConfig.TSDB.OutOfOrderCapMax,
18821866
}, nil)
18831867
if err != nil {
18841868
return nil, errors.Wrapf(err, "failed to open TSDB: %s", udir)

pkg/util/validation/limits.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,9 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) {
136136
f.IntVar(&l.MaxLabelNamesPerSeries, "validation.max-label-names-per-series", 30, "Maximum number of label names per series.")
137137
f.IntVar(&l.MaxLabelsSizeBytes, "validation.max-labels-size-bytes", 0, "Maximum combined size in bytes of all labels and label values accepted for a series. 0 to disable the limit.")
138138
f.IntVar(&l.MaxMetadataLength, "validation.max-metadata-length", 1024, "Maximum length accepted for metric metadata. Metadata refers to Metric Name, HELP and UNIT.")
139-
f.BoolVar(&l.RejectOldSamples, "validation.reject-old-samples", false, "Deprecated (use ingester.out-of-order-time-window instead): Reject old samples.")
139+
f.BoolVar(&l.RejectOldSamples, "validation.reject-old-samples", false, "Reject old samples.")
140140
_ = l.RejectOldSamplesMaxAge.Set("14d")
141-
f.Var(&l.RejectOldSamplesMaxAge, "validation.reject-old-samples.max-age", "Deprecated (use ingester.out-of-order-time-window instead): Maximum accepted sample age before rejecting.")
141+
f.Var(&l.RejectOldSamplesMaxAge, "validation.reject-old-samples.max-age", "Maximum accepted sample age before rejecting.")
142142
_ = l.CreationGracePeriod.Set("10m")
143143
f.Var(&l.CreationGracePeriod, "validation.create-grace-period", "Duration which table will be created/deleted before/after it's needed; we won't accept sample from before this time.")
144144
f.BoolVar(&l.EnforceMetricName, "validation.enforce-metric-name", true, "Enforce every sample has a metric name.")

0 commit comments

Comments
 (0)