Skip to content

Commit ba49762

Browse files
cyriltovenapracucci
authored andcommitted
Improve the frontend slow query logs.
This will help for the log to be more readable, parsable. Signed-off-by: Cyril Tovena <[email protected]>
1 parent 204564f commit ba49762

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

pkg/querier/frontend/frontend.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"net/http"
1212
"net/url"
1313
"path"
14+
"strings"
1415
"sync"
1516
"time"
1617

@@ -23,6 +24,8 @@ import (
2324
"github.com/weaveworks/common/httpgrpc"
2425
"github.com/weaveworks/common/httpgrpc/server"
2526
"github.com/weaveworks/common/user"
27+
28+
"github.com/cortexproject/cortex/pkg/util"
2629
)
2730

2831
const (
@@ -152,27 +155,26 @@ func (f *Frontend) Handler() http.Handler {
152155
}
153156

154157
func (f *Frontend) handle(w http.ResponseWriter, r *http.Request) {
155-
userID, err := user.ExtractOrgID(r.Context())
156-
if err != nil {
157-
server.WriteError(w, err)
158-
return
159-
}
160158

161159
startTime := time.Now()
162160
resp, err := f.roundTripper.RoundTrip(r)
163161
queryResponseTime := time.Since(startTime)
164162

165163
if f.cfg.LogQueriesLongerThan > 0 && queryResponseTime > f.cfg.LogQueriesLongerThan {
166-
logMessage := []interface{}{"msg", "slow query",
167-
"org_id", userID,
168-
"url", fmt.Sprintf("http://%s", r.Host+r.RequestURI),
164+
logMessage := []interface{}{
165+
"msg", "slow query",
166+
"host", r.Host,
167+
"path", r.URL.Path,
169168
"time_taken", queryResponseTime.String(),
170169
}
170+
for k, v := range r.URL.Query() {
171+
append(logMessage, fmt.Sprintf("qs_%s", k), strings.Join(v, ","))
172+
}
171173
pf := r.PostForm.Encode()
172174
if pf != "" {
173175
logMessage = append(logMessage, "body", pf)
174176
}
175-
level.Info(f.log).Log(logMessage...)
177+
level.Info(util.WithContext(r.Context(), util.Logger)).Log(logMessage...)
176178
}
177179

178180
if err != nil {

0 commit comments

Comments
 (0)