Skip to content

Commit bc2588c

Browse files
authored
Fix spans under BucketStores.Series span. (#2669)
Signed-off-by: Peter Štibraný <[email protected]>
1 parent 8624712 commit bc2588c

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

pkg/storegateway/bucket_stores.go

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,10 @@ func (u *BucketStores) syncUsersBlocks(ctx context.Context, f func(context.Conte
186186

187187
// Series makes a series request to the underlying user bucket store.
188188
func (u *BucketStores) Series(req *storepb.SeriesRequest, srv storepb.Store_SeriesServer) error {
189-
log, ctx := spanlogger.New(srv.Context(), "BucketStores.Series")
190-
defer log.Span.Finish()
189+
spanLog, spanCtx := spanlogger.New(srv.Context(), "BucketStores.Series")
190+
defer spanLog.Span.Finish()
191191

192-
userID := getUserIDFromGRPCContext(ctx)
192+
userID := getUserIDFromGRPCContext(spanCtx)
193193
if userID == "" {
194194
return fmt.Errorf("no userID")
195195
}
@@ -199,7 +199,10 @@ func (u *BucketStores) Series(req *storepb.SeriesRequest, srv storepb.Store_Seri
199199
return nil
200200
}
201201

202-
return store.Series(req, srv)
202+
return store.Series(req, spanSeriesServer{
203+
Store_SeriesServer: srv,
204+
ctx: spanCtx,
205+
})
203206
}
204207

205208
func (u *BucketStores) getStore(userID string) *store.BucketStore {
@@ -331,3 +334,13 @@ func (r *ReplicaLabelRemover) Modify(_ context.Context, metas map[ulid.ULID]*tha
331334
}
332335
return nil
333336
}
337+
338+
type spanSeriesServer struct {
339+
storepb.Store_SeriesServer
340+
341+
ctx context.Context
342+
}
343+
344+
func (s spanSeriesServer) Context() context.Context {
345+
return s.ctx
346+
}

0 commit comments

Comments
 (0)