Add more validation and test on instance_limits

Signed-off-by: Justin Jung <[email protected]>

Author: justinjung04

pkg/configs/instance_limits.go

@@ -20,10 +20,18 @@ func (cfg *InstanceLimits) RegisterFlagsWithPrefix(f *flag.FlagSet, prefix strin
 }
 
 func (cfg *InstanceLimits) Validate(monitoredResources flagext.StringSliceCSV) error {
+	if cfg.CPUUtilization > 1 || cfg.CPUUtilization < 0 {
+		return errors.New("cpu_utilization must be between 0 and 1")
+	}
+
 	if cfg.CPUUtilization > 0 && !strings.Contains(monitoredResources.String(), string(resource.CPU)) {
 		return errors.New("monitored_resources config must include \"cpu\" as well")
 	}
 
+	if cfg.HeapUtilization > 1 || cfg.HeapUtilization < 0 {
+		return errors.New("heap_utilization must be between 0 and 1")
+	}
+
 	if cfg.HeapUtilization > 0 && !strings.Contains(monitoredResources.String(), string(resource.Heap)) {
 		return errors.New("monitored_resources config must include \"heap\" as well")
 	}

pkg/configs/instance_limits_test.go

@@ -0,0 +1,64 @@
+package configs
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func Test_Validate(t *testing.T) {
+	for name, tc := range map[string]struct {
+		instanceLimits     InstanceLimits
+		monitoredResources []string
+		err                error
+	}{
+		"correct config should pass validation": {
+			instanceLimits: InstanceLimits{
+				CPUUtilization:  0.5,
+				HeapUtilization: 0.5,
+			},
+			monitoredResources: []string{"cpu", "heap"},
+			err:                nil,
+		},
+		"utilization config less than 0 should fail validation": {
+			instanceLimits: InstanceLimits{
+				CPUUtilization:  -0.5,
+				HeapUtilization: 0.5,
+			},
+			monitoredResources: []string{"cpu", "heap"},
+			err:                errors.New("cpu_utilization must be between 0 and 1"),
+		},
+		"utilization config greater than 1 should fail validation": {
+			instanceLimits: InstanceLimits{
+				CPUUtilization:  0.5,
+				HeapUtilization: 1.5,
+			},
+			monitoredResources: []string{"cpu", "heap"},
+			err:                errors.New("heap_utilization must be between 0 and 1"),
+		},
+		"missing cpu in monitored_resources config should fail validation": {
+			instanceLimits: InstanceLimits{
+				CPUUtilization: 0.5,
+			},
+			monitoredResources: []string{"heap"},
+			err:                errors.New("monitored_resources config must include \"cpu\" as well"),
+		},
+		"missing heap in monitored_resources config should fail validation": {
+			instanceLimits: InstanceLimits{
+				HeapUtilization: 0.5,
+			},
+			monitoredResources: []string{"cpu"},
+			err:                errors.New("monitored_resources config must include \"heap\" as well"),
+		},
+	} {
+		t.Run(name, func(t *testing.T) {
+			err := tc.instanceLimits.Validate(tc.monitoredResources)
+			if tc.err != nil {
+				require.Errorf(t, err, tc.err.Error())
+			} else {
+				require.NoError(t, err)
+			}
+		})
+	}
+}