Break out of loop entirely when background cache queue is full

bboreham · bboreham · commit cae51e8a013c · 2020-02-28T14:04:44.000Z
Signed-off-by: Bryan Boreham &lt;bryan@weave.works&gt;
diff --git a/pkg/chunk/cache/background.go b/pkg/chunk/cache/background.go
@@ -103,7 +103,7 @@ func (c *backgroundCache) Store(ctx context.Context, keys []string, bufs [][]byt
 			if sp != nil {
 				sp.LogFields(otlog.Int("dropped", len(keys)))
 			}
-			break // queue is full; give up
+			return // queue is full; give up
 		}
 		keys = keys[num:]
 		bufs = bufs[num:]

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ func (c *backgroundCache) Store(ctx context.Context, keys []string, bufs [][]byt`
`103`	`103`	`if sp != nil {`
`104`	`104`	`sp.LogFields(otlog.Int("dropped", len(keys)))`
`105`	`105`	`}`
`106`		`- break // queue is full; give up`
	`106`	`+ return // queue is full; give up`
`107`	`107`	`}`
`108`	`108`	`keys = keys[num:]`
`109`	`109`	`bufs = bufs[num:]`