Fix over-counting of cache writes

bboreham · bboreham · commit cf5d9b0afd51 · 2020-02-20T10:25:33.000Z
Signed-off-by: Bryan Boreham &lt;bryan@weave.works&gt;
diff --git a/pkg/chunk/cache/background.go b/pkg/chunk/cache/background.go
@@ -96,7 +96,7 @@ func (c *backgroundCache) Store(ctx context.Context, keys []string, bufs [][]byt
 		}
 		select {
 		case c.bgWrites <- bgWrite:
-			c.queueLength.Add(float64(len(keys)))
+			c.queueLength.Add(float64(num))
 		default:
 			c.droppedWriteBack.Add(float64(len(keys)))
 			sp := opentracing.SpanFromContext(ctx)

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func (c *backgroundCache) Store(ctx context.Context, keys []string, bufs [][]byt`
`96`	`96`	`}`
`97`	`97`	`select {`
`98`	`98`	`case c.bgWrites <- bgWrite:`
`99`		`- c.queueLength.Add(float64(len(keys)))`
	`99`	`+ c.queueLength.Add(float64(num))`
`100`	`100`	`default:`
`101`	`101`	`c.droppedWriteBack.Add(float64(len(keys)))`
`102`	`102`	`sp := opentracing.SpanFromContext(ctx)`