Do not call the Thanos JSON index header as 'legacy'

Signed-off-by: Marco Pracucci <[email protected]>

Author: pracucci

docs/configuration/config-file-reference.md

@@ -2199,7 +2199,7 @@ bucket_store:
   [meta_sync_concurrency: <int> | default = 20]
 
   # Whether the bucket store should use the binary index header. If false, it
-  # uses the legacy JSON index header.
+  # uses the JSON index header.
   # CLI flag: -experimental.tsdb.bucket-store.binary-index-header-enabled
   [binary_index_header_enabled: <boolean> | default = true]
 

docs/operations/blocks-storage.md

@@ -167,7 +167,7 @@ tsdb:
     [meta_sync_concurrency: <int> | default = 20]
 
     # Whether the bucket store should use the binary index header. If false, it
-    # uses the legacy JSON index header.
+    # uses the JSON index header.
     # CLI flag: -experimental.tsdb.bucket-store.binary-index-header-enabled
     [binary_index_header_enabled: <boolean> | default = true]
 

pkg/storage/tsdb/config.go

@@ -170,7 +170,7 @@ func (cfg *BucketStoreConfig) RegisterFlags(f *flag.FlagSet) {
 	f.IntVar(&cfg.TenantSyncConcurrency, "experimental.tsdb.bucket-store.tenant-sync-concurrency", 10, "Maximum number of concurrent tenants synching blocks.")
 	f.IntVar(&cfg.BlockSyncConcurrency, "experimental.tsdb.bucket-store.block-sync-concurrency", 20, "Maximum number of concurrent blocks synching per tenant.")
 	f.IntVar(&cfg.MetaSyncConcurrency, "experimental.tsdb.bucket-store.meta-sync-concurrency", 20, "Number of Go routines to use when syncing block meta files from object storage per tenant.")
-	f.BoolVar(&cfg.BinaryIndexHeader, "experimental.tsdb.bucket-store.binary-index-header-enabled", true, "Whether the bucket store should use the binary index header. If false, it uses the legacy JSON index header.")
+	f.BoolVar(&cfg.BinaryIndexHeader, "experimental.tsdb.bucket-store.binary-index-header-enabled", true, "Whether the bucket store should use the binary index header. If false, it uses the JSON index header.")
 	f.DurationVar(&cfg.ConsistencyDelay, "experimental.tsdb.bucket-store.consistency-delay", 0, "Minimum age of a block before it's being read. Set it to safe value (e.g 30m) if your object storage is eventually consistent. GCS and S3 are (roughly) strongly consistent.")
 }