Skip to content

Commit fb6f97e

Browse files
committed
upstream promql compatibility changes
Signed-off-by: Owen Diehl <[email protected]>
1 parent 6abe6a2 commit fb6f97e

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

pkg/querier/astmapper/astmapper_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,19 @@ func TestCloneNode(t *testing.T) {
1818
// simple unmodified case
1919
{
2020
&promql.BinaryExpr{
21-
Op: promql.ItemADD,
21+
Op: promql.ADD,
2222
LHS: &promql.NumberLiteral{Val: 1},
2323
RHS: &promql.NumberLiteral{Val: 1},
2424
},
2525
&promql.BinaryExpr{
26-
Op: promql.ItemADD,
26+
Op: promql.ADD,
2727
LHS: &promql.NumberLiteral{Val: 1},
2828
RHS: &promql.NumberLiteral{Val: 1},
2929
},
3030
},
3131
{
3232
&promql.AggregateExpr{
33-
Op: promql.ItemSum,
33+
Op: promql.SUM,
3434
Without: true,
3535
Expr: &promql.VectorSelector{
3636
Name: "some_metric",
@@ -41,7 +41,7 @@ func TestCloneNode(t *testing.T) {
4141
Grouping: []string{"foo"},
4242
},
4343
&promql.AggregateExpr{
44-
Op: promql.ItemSum,
44+
Op: promql.SUM,
4545
Without: true,
4646
Expr: &promql.VectorSelector{
4747
Name: "some_metric",

pkg/querier/astmapper/embedded.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func OrSquasher(nodes ...promql.Node) (promql.Expr, error) {
8989
combined := nodes[0]
9090
for i := 1; i < len(nodes); i++ {
9191
combined = &promql.BinaryExpr{
92-
Op: promql.ItemLOR,
92+
Op: promql.LOR,
9393
LHS: combined.(promql.Expr),
9494
RHS: nodes[i].(promql.Expr),
9595
}

pkg/querier/astmapper/parallel.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import (
66
)
77

88
var summableAggregates = map[promql.ItemType]struct{}{
9-
promql.ItemSum: {},
10-
promql.ItemMin: {},
11-
promql.ItemMax: {},
12-
promql.ItemTopK: {},
13-
promql.ItemBottomK: {},
14-
promql.ItemCount: {},
9+
promql.SUM: {},
10+
promql.MIN: {},
11+
promql.MAX: {},
12+
promql.TOPK: {},
13+
promql.BOTTOMK: {},
14+
promql.COUNT: {},
1515
}
1616

1717
var nonParallelFuncs = []string{

pkg/querier/astmapper/parallel_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ func TestCanParallel(t *testing.T) {
1818
// simple sum
1919
{
2020
&promql.AggregateExpr{
21-
Op: promql.ItemSum,
21+
Op: promql.SUM,
2222
Without: true,
2323
Expr: &promql.VectorSelector{
2424
Name: "some_metric",
@@ -39,11 +39,11 @@ func TestCanParallel(t *testing.T) {
3939
*/
4040
{
4141
&promql.AggregateExpr{
42-
Op: promql.ItemSum,
42+
Op: promql.SUM,
4343
Expr: &promql.BinaryExpr{
44-
Op: promql.ItemDIV,
44+
Op: promql.DIV,
4545
LHS: &promql.AggregateExpr{
46-
Op: promql.ItemSum,
46+
Op: promql.SUM,
4747
Grouping: []string{"foo"},
4848
Expr: &promql.VectorSelector{
4949
Name: "idk",
@@ -52,7 +52,7 @@ func TestCanParallel(t *testing.T) {
5252
}},
5353
},
5454
RHS: &promql.AggregateExpr{
55-
Op: promql.ItemSum,
55+
Op: promql.SUM,
5656
Grouping: []string{"foo"},
5757
Expr: &promql.VectorSelector{
5858
Name: "idk",
@@ -67,7 +67,7 @@ func TestCanParallel(t *testing.T) {
6767
// sum by (foo) bar1{baz=”blip”}[1m]) ---- this is the first leg of the above
6868
{
6969
&promql.AggregateExpr{
70-
Op: promql.ItemSum,
70+
Op: promql.SUM,
7171
Grouping: []string{"foo"},
7272
Expr: &promql.VectorSelector{
7373
Name: "idk",

pkg/querier/astmapper/shard_summer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func (summer *shardSummer) MapNode(node promql.Node) (promql.Node, bool, error)
5959

6060
switch n := node.(type) {
6161
case *promql.AggregateExpr:
62-
if CanParallel(n) && n.Op == promql.ItemSum {
62+
if CanParallel(n) && n.Op == promql.SUM {
6363
result, err := summer.shardSum(n)
6464
return result, true, err
6565
}

0 commit comments

Comments
 (0)