Skip to content

Ingestion latency spikes when discarding metrics due to limits #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gouthamve opened this issue Mar 25, 2019 · 2 comments · Fixed by #1922
Closed

Ingestion latency spikes when discarding metrics due to limits #1301

gouthamve opened this issue Mar 25, 2019 · 2 comments · Fixed by #1922

Comments

@gouthamve
Copy link
Contributor

image

We're seeing consistent spikes in ingester /cortex.Ingester/Push latency when there is an uptick in the samples dropped due to limits.

Needs to be investigated further.
This was referenced Jul 10, 2019
Merged
Closed
@bboreham
Copy link
Contributor

bboreham commented Aug 7, 2019

@gouthamve do you see any improvement after #1497 ?

@bboreham
Copy link
Contributor

I have a theory what causes this.

For each rejection, userState.getSeries() calls httpgrpc.ErrorFromHTTPResponse(), which does a lot of memory-allocating, then returns it to Ingester.Push() which calls httpgrpc.HTTPResponseFromError() which does even more memory-allocating. Then Push() throws it all away except for the last error.

I recommend we use an error object that just holds a reference to the labels until called upon to format itself.

@bboreham bboreham mentioned this issue Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce memory usage from ingester Push() errors cortexproject/cortex
2 participants
@gouthamve @bboreham