Skip to content

Disable chunk trimming in Ingesters #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yeya24 opened this issue Oct 15, 2024 · 0 comments · Fixed by #6270
Closed

Disable chunk trimming in Ingesters #6269

yeya24 opened this issue Oct 15, 2024 · 0 comments · Fixed by #6270

Comments

@yeya24
Copy link
Contributor

yeya24 commented Oct 15, 2024

Is your feature request related to a problem? Please describe.
Similar to thanos-io/thanos#7815

If the requested time range is within the range of a chunk, then if chunks trimming enabled, Ingesters spend CPU decoding chunks and throw away samples that outside the requested time range.

This step is actually unnecessary because the query engine already drops samples that outside the requested time range so the CPU time spent on decoding chunks is wasted.

Describe the solution you'd like
Similar to thanos-io/thanos#7815, disable chunk trimming in the select hints in Ingester.

Additional context
It would be good to add a fuzzy (promqlsmith) tests to make sure disabling chunk trimming doesn't change query results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant