-
Notifications
You must be signed in to change notification settings - Fork 818
Make NameValidationScheme configurable #6702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, @yeya24 can I help with it? |
@yumosx Yes please go ahead. |
@yumosx Are you working on it? If not, can I try this one? |
I've been quite busy recently, you can try it. |
Okay. Thank you. @yumosx |
Hello @yeya24, This might be a bit silly to ask, but I wanted to confirm how the user would set that flag? By CMD variable, env variable or something else ?? |
It will be both a flag and field in the config file. |
Okay. Thank you. |
Hello @yeya24, I have created a draft PR for this commit. Adding tests is left. Just wanted to confirm by you, if I am on the right path in implementing the changes required by this issue. Once you confirm, I will add the tests and make the PR ready for review. I am sorry for doing this, I don't have much experience in OSS contribution, so. |
Is your feature request related to a problem? Please describe.
Now
NameValidationScheme
is hardcoded to legacy. We want to allow users to enableUTF-8
validation mode behind a flag.Describe the solution you'd like
Add a flag to turn on
UTF-8
validation mode. Make sure to cover unit testsThe text was updated successfully, but these errors were encountered: