Skip to content

Make NameValidationScheme configurable #6702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeya24 opened this issue Apr 16, 2025 · 9 comments · May be fixed by #6733
Open

Make NameValidationScheme configurable #6702

yeya24 opened this issue Apr 16, 2025 · 9 comments · May be fixed by #6733
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted type/feature

Comments

@yeya24
Copy link
Contributor

yeya24 commented Apr 16, 2025

Is your feature request related to a problem? Please describe.
Now NameValidationScheme is hardcoded to legacy. We want to allow users to enable UTF-8 validation mode behind a flag.

Describe the solution you'd like

Add a flag to turn on UTF-8 validation mode. Make sure to cover unit tests

@dosubot dosubot bot added the type/feature label Apr 16, 2025
@yeya24 yeya24 added help wanted good first issue These are great first issues. If you are looking for a place to start, start here! labels Apr 16, 2025
@yumosx
Copy link

yumosx commented Apr 16, 2025

Hi, @yeya24 can I help with it?

@yeya24
Copy link
Contributor Author

yeya24 commented Apr 16, 2025

@yumosx Yes please go ahead.

@av153k
Copy link

av153k commented Apr 29, 2025

@yumosx Are you working on it? If not, can I try this one?

@yumosx
Copy link

yumosx commented Apr 29, 2025

I've been quite busy recently, you can try it.

@av153k
Copy link

av153k commented Apr 29, 2025

Okay. Thank you. @yumosx

@av153k
Copy link

av153k commented Apr 29, 2025

Hello @yeya24, This might be a bit silly to ask, but I wanted to confirm how the user would set that flag? By CMD variable, env variable or something else ??

@yeya24
Copy link
Contributor Author

yeya24 commented May 2, 2025

It will be both a flag and field in the config file.

@av153k
Copy link

av153k commented May 4, 2025

Okay. Thank you.

@av153k
Copy link

av153k commented May 8, 2025

Hello @yeya24, I have created a draft PR for this commit. Adding tests is left. Just wanted to confirm by you, if I am on the right path in implementing the changes required by this issue. Once you confirm, I will add the tests and make the PR ready for review. I am sorry for doing this, I don't have much experience in OSS contribution, so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! help wanted type/feature
Projects
None yet
3 participants