diff --git a/CHANGELOG.md b/CHANGELOG.md index 22299f8eff6..7bd8c2a6f64 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ * [CHANGE] Server: Instrument `cortex_request_duration_seconds` metric with native histogram. If `native-histograms` feature is enabled in monitoring Prometheus then the metric name needs to be updated in your dashboards. #6056 * [CHANGE] Distributor/Ingester: Change `cortex_distributor_ingester_appends_total`, `cortex_distributor_ingester_append_failures_total`, `cortex_distributor_ingester_queries_total`, and `cortex_distributor_ingester_query_failures_total` metrics to use the ingester ID instead of its IP as the label value. #6078 * [CHANGE] OTLP: Set `AddMetricSuffixes` to true to always enable metric name normalization. #6136 +* [CHANGE] Querier: Deprecate and enable by default `querier.ingester-metadata-streaming` flag. #6147 * [FEATURE] Ingester/Distributor: Experimental: Enable native histogram ingestion via `-blocks-storage.tsdb.enable-native-histograms` flag. #5986 #6010 #6020 * [FEATURE] Querier: Enable querying native histogram chunks. #5944 #6031 * [FEATURE] Query Frontend: Support native histogram in query frontend response. #5996 #6043 diff --git a/docs/blocks-storage/querier.md b/docs/blocks-storage/querier.md index a9206c82ba0..8cd0b9f0085 100644 --- a/docs/blocks-storage/querier.md +++ b/docs/blocks-storage/querier.md @@ -104,9 +104,10 @@ querier: # CLI flag: -querier.timeout [timeout: | default = 2m] - # Use streaming RPCs for metadata APIs from ingester. + # Deprecated (This feature will be always on after v1.18): Use streaming RPCs + # for metadata APIs from ingester. # CLI flag: -querier.ingester-metadata-streaming - [ingester_metadata_streaming: | default = false] + [ingester_metadata_streaming: | default = true] # Maximum number of samples a single query can load into memory. # CLI flag: -querier.max-samples diff --git a/docs/configuration/config-file-reference.md b/docs/configuration/config-file-reference.md index 745b612fe73..72b4d3acf09 100644 --- a/docs/configuration/config-file-reference.md +++ b/docs/configuration/config-file-reference.md @@ -3698,9 +3698,10 @@ The `querier_config` configures the Cortex querier. # CLI flag: -querier.timeout [timeout: | default = 2m] -# Use streaming RPCs for metadata APIs from ingester. +# Deprecated (This feature will be always on after v1.18): Use streaming RPCs +# for metadata APIs from ingester. # CLI flag: -querier.ingester-metadata-streaming -[ingester_metadata_streaming: | default = false] +[ingester_metadata_streaming: | default = true] # Maximum number of samples a single query can load into memory. # CLI flag: -querier.max-samples diff --git a/pkg/querier/querier.go b/pkg/querier/querier.go index 9b0f5d447fb..21fd33e1f79 100644 --- a/pkg/querier/querier.go +++ b/pkg/querier/querier.go @@ -108,7 +108,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { cfg.StoreGatewayClient.RegisterFlagsWithPrefix("querier.store-gateway-client", f) f.IntVar(&cfg.MaxConcurrent, "querier.max-concurrent", 20, "The maximum number of concurrent queries.") f.DurationVar(&cfg.Timeout, "querier.timeout", 2*time.Minute, "The timeout for a query.") - f.BoolVar(&cfg.IngesterMetadataStreaming, "querier.ingester-metadata-streaming", false, "Use streaming RPCs for metadata APIs from ingester.") + f.BoolVar(&cfg.IngesterMetadataStreaming, "querier.ingester-metadata-streaming", true, "Deprecated (This feature will be always on after v1.18): Use streaming RPCs for metadata APIs from ingester.") f.IntVar(&cfg.MaxSamples, "querier.max-samples", 50e6, "Maximum number of samples a single query can load into memory.") f.DurationVar(&cfg.QueryIngestersWithin, "querier.query-ingesters-within", 0, "Maximum lookback beyond which queries are not sent to ingester. 0 means all queries are sent to ingester.") f.BoolVar(&cfg.EnablePerStepStats, "querier.per-step-stats-enabled", false, "Enable returning samples stats per steps in query response.")