From ebbf118a30f625096b7924953d97642a4abe989d Mon Sep 17 00:00:00 2001 From: Vishnu Kumar Date: Sun, 19 May 2019 18:40:54 +0530 Subject: [PATCH] File.Exists instead of try-catch for HitsFile creation/update validation --- .../Instrumentation/ModuleTrackerTemplate.cs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/coverlet.core/Instrumentation/ModuleTrackerTemplate.cs b/src/coverlet.core/Instrumentation/ModuleTrackerTemplate.cs index 4689a56f3..f3ef11e54 100644 --- a/src/coverlet.core/Instrumentation/ModuleTrackerTemplate.cs +++ b/src/coverlet.core/Instrumentation/ModuleTrackerTemplate.cs @@ -82,8 +82,7 @@ public static void UnloadModule(object sender, EventArgs e) if (!createdNew) mutex.WaitOne(); - bool failedToCreateNewHitsFile = false; - try + if (!File.Exists(HitsFilePath)) { using (var fs = new FileStream(HitsFilePath, FileMode.CreateNew)) using (var bw = new BinaryWriter(fs)) @@ -95,12 +94,7 @@ public static void UnloadModule(object sender, EventArgs e) } } } - catch - { - failedToCreateNewHitsFile = true; - } - - if (failedToCreateNewHitsFile) + else { // Update the number of hits by adding value on disk with the ones on memory. // This path should be triggered only in the case of multiple AppDomain unloads.