resolves #94

Author: 2bndy5

clang_tools/install.py

@@ -14,7 +14,7 @@
 from . import release_tag
 
 from . import install_os, RESET_COLOR, suffix, YELLOW
-from .util import download_file, verify_sha512, get_sha_checksum
+from .util import download_file, verify_sha512, get_sha_checksum, parse_version
 
 
 #: This pattern is designed to match only the major version number.
@@ -29,11 +29,8 @@ def is_installed(tool_name: str, version: str) -> Optional[Path]:
 
     :returns: The path to the detected tool (if found), otherwise `None`.
     """
-    version_tuple = version.split(".")
+    version_tuple = parse_version(version)
     ver_major = version_tuple[0]
-    if len(version_tuple) < 3:
-        # append minor and patch version numbers if not specified
-        version_tuple += ("0",) * (3 - len(version_tuple))
     exe_name = (
         f"{tool_name}" + (f"-{ver_major}" if install_os != "windows" else "") + suffix
     )
@@ -59,7 +56,7 @@ def is_installed(tool_name: str, version: str) -> Optional[Path]:
     path = Path(path).resolve()
     print("at", str(path))
     ver_num = ver_num.groups(0)[0].decode(encoding="utf-8").split(".")
-    if ver_num is None or ver_num[0] != ver_major:
+    if ver_num is None or ver_num[0] != str(ver_major):
         return None  # version is unknown or not the desired major release
     return path
 

clang_tools/main.py

@@ -4,10 +4,12 @@
 
 The module containing main entrypoint function.
 """
+
 import argparse
 
 from .install import install_clang_tools, uninstall_clang_tools
 from . import RESET_COLOR, YELLOW
+from .util import parse_version
 
 
 def get_parser() -> argparse.ArgumentParser:
@@ -66,13 +68,19 @@ def main():
     if args.uninstall:
         uninstall_clang_tools(args.uninstall, args.directory)
     elif args.install:
-        install_clang_tools(
-            args.install,
-            args.tool,
-            args.directory,
-            args.overwrite,
-            args.no_progress_bar,
-        )
+        if parse_version(args.install) != (0, 0, 0):
+            install_clang_tools(
+                args.install,
+                args.tool,
+                args.directory,
+                args.overwrite,
+                args.no_progress_bar,
+            )
+        else:
+            print(
+                f"{YELLOW}The version specified is not a semantic",
+                f"specification{RESET_COLOR}",
+            )
     else:
         print(
             f"{YELLOW}Nothing to do because `--install` and `--uninstall`",

clang_tools/util.py

@@ -8,7 +8,7 @@
 import hashlib
 from pathlib import Path
 import urllib.request
-from typing import Optional
+from typing import Optional, Tuple
 from urllib.error import HTTPError
 from http.client import HTTPResponse
 
@@ -99,3 +99,21 @@ def verify_sha512(checksum: str, exe: bytes) -> bool:
         # released checksum's include the corresponding filename (which we don't need)
         checksum = checksum.split(" ", 1)[0]
     return checksum == hashlib.sha512(exe).hexdigest()
+
+
+def parse_version(version: str) -> Tuple[int]:
+    """Parse the given version string into a semantic specification.
+
+    :param version: The version specification as a string.
+
+    :returns: A tuple of ints that describes the major, minor, and patch versions.
+        If the version is a path, then the tuple is just 3 zeros.
+    """
+    version_tuple = version.split(".")
+    if len(version_tuple) < 3:
+        # append minor and patch version numbers if not specified
+        version_tuple += ["0"] * (3 - len(version_tuple))
+    try:
+        return tuple([int(x) for x in version_tuple])
+    except ValueError:
+        return (0, 0, 0)

tests/test_util.py

@@ -1,9 +1,15 @@
 """Tests related to the utility functions."""
+
 from pathlib import Path, PurePath
 import pytest
 from clang_tools import install_os
 from clang_tools.install import clang_tools_binary_url
-from clang_tools.util import check_install_os, download_file, get_sha_checksum
+from clang_tools.util import (
+    check_install_os,
+    download_file,
+    get_sha_checksum,
+    parse_version,
+)
 from clang_tools import release_tag
 
 
@@ -33,3 +39,9 @@ def test_get_sha(monkeypatch: pytest.MonkeyPatch):
     )
     url = clang_tools_binary_url("clang-format", "12", tag=release_tag)
     assert get_sha_checksum(url) == expected
+
+
+def test_version_path():
+    """Tests version parsing when given specification is a path."""
+    version = "some/path/to/bin/folder"
+    assert parse_version(version) == (0, 0, 0)