Skip to content

fix skip tests #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shenxianpeng opened this issue Mar 7, 2024 · 3 comments · Fixed by #50
Closed

fix skip tests #42

shenxianpeng opened this issue Mar 7, 2024 · 3 comments · Fixed by #50
Labels
enhancement New feature or request

Comments

@shenxianpeng
Copy link
Collaborator

shenxianpeng commented Mar 7, 2024 •
edited
Loading

The tests are failing on github actions now, because clang tools are already installed there, so the tests that assumed that when starting the tests, we don't have the tools fail.

Will think about how to actually test that the installation works.

Originally posted in #29 (comment)
@shenxianpeng shenxianpeng changed the title fix skip tests fix skipped tests Mar 7, 2024
@shenxianpeng shenxianpeng changed the title fix skipped tests fix skip tests Mar 7, 2024
@shenxianpeng
Copy link
Collaborator Author

For example

cpp-linter-hooks/tests/test_clang_tidy.py

Line 7 in 12981fe

@pytest.mark.skip(reason="see https://github.com/cpp-linter/cpp-linter-hooks/pull/29")

@shenxianpeng shenxianpeng added the enhancement New feature or request label Mar 14, 2024
@shenxianpeng shenxianpeng mentioned this issue Apr 28, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label May 14, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 14, 2024
@shenxianpeng shenxianpeng mentioned this issue Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove @pytest.mark.skip cpp-linter/cpp-linter-hooks
1 participant
@shenxianpeng