ready PR for merging

do thread comments when run as action

Author: 2bndy5

.github/workflows/cpp-lint-action.yml

@@ -2,6 +2,9 @@ name: cpp-linter as action
 
 on:
   workflow_dispatch:
+  pull_request:
+    types: [opened, reopened, synchronize]
+  push:
 
 
 jobs:
@@ -28,12 +31,12 @@ jobs:
       # - name: Generate compilation database
       #   if: steps.cache-build.outputs.cache-hit != 'true'
       #   run: mkdir build && cmake -Bbuild src
-      
+
       # - name: Move database to src folder
       #   run: mv build/compile_commands.json src/
 
       - name: run linter as action
-        uses: cpp-linter/cpp-linter-action@backlogged-updates
+        uses: cpp-linter/cpp-linter-action@latest
         id: linter
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -45,7 +48,7 @@ jobs:
           # database: build
           verbosity: 9
           version: ${{ matrix.clang-version }}
-          file-annotations: ${{ matrix.clang-version == '12' }}
+          thread-comments: ${{ matrix.clang-version == '12' }}
 
       - name: Fail fast?!
         if: steps.linter.outputs.checks-failed > 0

.github/workflows/cpp-lint-package.yml

@@ -2,35 +2,38 @@ name: cpp-linter as pkg
 
 on:
   workflow_dispatch:
+  pull_request:
+    types: [opened, reopened, synchronize]
+  push:
 
 jobs:
   cpp-linter:
     runs-on: windows-latest
 
     strategy:
       matrix:
-        clang-version: ['9','10', '11', '12', '13', '14']
+        clang-version: ['7', '8', '9','10', '11', '12', '13', '14']
         repo: ['cpp-linter/cpp-linter-action']
-        branch: ['backlogged-updates']
+        branch: ['latest']
       fail-fast: false
 
     steps:
 
       - uses: actions/checkout@v3
         with:
           submodules: true
-      - uses: actions/setup-python@v3
+
+      - uses: actions/setup-python@v4
+
+      - name: install workflow deps
+        run: python -m pip install clang-tools git+https://github.com/${{ matrix.repo }}/@${{ matrix.branch }}
+
       - name: Install clang-tools
-        uses: KyleMayes/install-llvm-action@v1
-        with:
-          version: ${{ matrix.clang-version }}
-          directory: ${{ runner.temp }}/llvm
-
-      - name: Install linter package
-        run: python3 -m pip install git+https://github.com/${{ matrix.repo }}/@${{ matrix.branch }}
-      
-      - uses: seanmiddleditch/gha-setup-vsdevenv@v4
-      
+        run: clang-tools -install ${{ matrix.clang-version }} --directory ${{ runner.temp }}/llvm
+
+      - name: Setup VS dev env
+        uses: seanmiddleditch/gha-setup-vsdevenv@v4
+
       - name: Cache the build artifacts
         id: cache-build
         uses: actions/cache@v3

src/demo.cpp

@@ -8,8 +8,7 @@ size_t dummyFunc(size_t i) { return i; }
 
 int main()
 {
-    for (;;)
-        break;
+    for (;;) break;
 
     printf("Hello world!\n");
 

src/demo.hpp

@@ -9,7 +9,7 @@ class Dummy {
     public:
     void *not_usefull(char *str){
         useless = str;
-        return nullptr;
+        return 0;
     }
 };