Skip to content

Commit f451ade

Browse files
committed
ready PR for merging
do thread comments when run as action revert some changes to the demo srcs
1 parent b06637f commit f451ade

File tree

3 files changed

+19
-18
lines changed

3 files changed

+19
-18
lines changed

.github/workflows/cpp-lint-action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ jobs:
2828
# - name: Generate compilation database
2929
# if: steps.cache-build.outputs.cache-hit != 'true'
3030
# run: mkdir build && cmake -Bbuild src
31-
31+
3232
# - name: Move database to src folder
3333
# run: mv build/compile_commands.json src/
3434

3535
- name: run linter as action
36-
uses: cpp-linter/cpp-linter-action@backlogged-updates
36+
uses: cpp-linter/cpp-linter-action@latest
3737
id: linter
3838
env:
3939
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -45,7 +45,7 @@ jobs:
4545
# database: build
4646
verbosity: 9
4747
version: ${{ matrix.clang-version }}
48-
file-annotations: ${{ matrix.clang-version == '12' }}
48+
thread-comments: ${{ matrix.clang-version == '12' }}
4949

5050
- name: Fail fast?!
5151
if: steps.linter.outputs.checks-failed > 0

.github/workflows/cpp-lint-package.yml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,28 +9,28 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
clang-version: ['9','10', '11', '12', '13', '14']
12+
clang-version: ['7', '8', '9','10', '11', '12', '13', '14']
1313
repo: ['cpp-linter/cpp-linter-action']
14-
branch: ['backlogged-updates']
14+
branch: ['latest']
1515
fail-fast: false
1616

1717
steps:
1818

1919
- uses: actions/checkout@v3
2020
with:
2121
submodules: true
22-
- uses: actions/setup-python@v3
22+
23+
- uses: actions/setup-python@v4
24+
25+
- name: install workflow deps
26+
run: python -m pip install clang-tools git+https://github.com/${{ matrix.repo }}/@${{ matrix.branch }}
27+
2328
- name: Install clang-tools
24-
uses: KyleMayes/install-llvm-action@v1
25-
with:
26-
version: ${{ matrix.clang-version }}
27-
directory: ${{ runner.temp }}/llvm
28-
29-
- name: Install linter package
30-
run: python3 -m pip install git+https://github.com/${{ matrix.repo }}/@${{ matrix.branch }}
31-
32-
- uses: seanmiddleditch/gha-setup-vsdevenv@v4
33-
29+
run: clang-tools -install ${{ matrix.clang-version }} --directory ${{ runner.temp }}/llvm
30+
31+
- name: Setup VS dev env
32+
uses: seanmiddleditch/gha-setup-vsdevenv@v4
33+
3434
- name: Cache the build artifacts
3535
id: cache-build
3636
uses: actions/cache@v3

src/demo.hpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class Dummy {
99
public:
1010
void *not_usefull(char *str){
1111
useless = str;
12-
return nullptr;
12+
return 0;
1313
}
1414
};
1515

@@ -37,4 +37,5 @@ class Dummy {
3737
struct LongDiff
3838
{
3939
long diff;
40-
};
40+
41+
};

0 commit comments

Comments
 (0)