Skip to content

Can ffmpeg commands be canceled #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tspecht opened this issue Oct 18, 2014 · 8 comments
Closed

Can ffmpeg commands be canceled #3

tspecht opened this issue Oct 18, 2014 · 8 comments

Comments

@tspecht
Copy link

tspecht commented Oct 18, 2014

Hey,

I tried cancelling my ffmpeg command in onDestory but the kill function provided is not working, any suggestions?

@taschik
Copy link

taschik commented Oct 21, 2014

I have the same issue here. The isFFmpegCommandRunning() function always returns False although the process is running. Any idea how to fix it?

@hiteshsondhi88
Copy link
Contributor

Hey, I am pretty busy these days. I will get back to this as soon as I can.

@grimaz
Copy link

grimaz commented Nov 24, 2014

It seems error in
public boolean isFFmpegCommandRunning() {
return ffmpegExecuteAsyncTask != null && ffmpegExecuteAsyncTask.isProcessCompleted();
}
which returns isProcessCompleted() => false, instead of !isProcessCompleted().

@gmxu
Copy link
Contributor

gmxu commented Dec 24, 2014

Also an error in killRunningProcesses() which I fixed by changing the && operator to a || operator.

public boolean killRunningProcesses() {
return Util.killAsync(ffmpegLoadLibraryAsyncTask) && Util.killAsync(ffmpegExecuteAsyncTask);
}

@hiteshsondhi88
Copy link
Contributor

yeah this should have been an ||.
Can you create a PR so that I can merge it ?

@Shahar2k5
Copy link

code still contains the && operator... :(

@andrewcross
Copy link

It looks like the && operator fix is in master, but not in the 0.2.5 build available via gradle

@sam7700
Copy link

sam7700 commented Mar 20, 2016

as on March 2016 is still the same on the gradle build and the aar linked in the main site, I think we can pretty much consider this not maintained anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants