Fix a bug (#1936)

naoyam · web-flow · commit ef98f360f6d3 · 2022-08-26T15:24:17.000-07:00
A bit uncomfortable not using an initialization list to initialize
value_, but can't think of any other way to workaround the c10::variant
deprecated problem.
diff --git a/torch/csrc/jit/codegen/cuda/dynamic_type.h b/torch/csrc/jit/codegen/cuda/dynamic_type.h
@@ -23,8 +23,8 @@ class TORCH_CUDA_CU_API IntOrDouble {
 
   // Avoid using copy constructor of c10::variant as it's
   // deprecated.
-  IntOrDouble(const IntOrDouble& other)
-      : IntOrDouble(other.is_int() ? other.as<int64_t>() : other.as<double>()) {
+  IntOrDouble(const IntOrDouble& other) {
+    value_ = other.value_;
   }
 
   // Explicitly define copy assignment operator as its implicit definition is

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@ class TORCH_CUDA_CU_API IntOrDouble {`
`23`	`23`
`24`	`24`	`// Avoid using copy constructor of c10::variant as it's`
`25`	`25`	`// deprecated.`
`26`		`- IntOrDouble(const IntOrDouble& other)`
`27`		`- : IntOrDouble(other.is_int() ? other.as<int64_t>() : other.as<double>()) {`
	`26`	`+ IntOrDouble(const IntOrDouble& other) {`
	`27`	`+ value_ = other.value_;`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`// Explicitly define copy assignment operator as its implicit definition is`