Skip to content

Commit b4ce50c

Browse files
committed
Upgrade should to avoid performance problems in node 7.x.
Node 7.x contains a performance regression which makes certain `instanceof` tests 100x slower: nodejs/node#9634 Upgrading `should` from 8.3.0 to 11.1.2 makes this performance problem go away when running our tests, for reasons I don't fully understand, but it seems to be related to: shouldjs/should.js@0737171 so perhaps the root of the performance problem is actually `should.not`, not the `instanceof` regression.
1 parent 07cb1e5 commit b4ce50c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@
2020
"devDependencies": {
2121
"jshint": "^2.9.1",
2222
"mocha": "^2.4.5",
23-
"should": "^8.3.0"
23+
"should": "^11.1.2"
2424
}
2525
}

0 commit comments

Comments
 (0)