Skip to content

Commit 8c0a477

Browse files
committed
Merge remote-tracking branch 'origin/main' into v7.x.x
2 parents 0874676 + c7bccdb commit 8c0a477

File tree

3 files changed

+41
-8
lines changed

3 files changed

+41
-8
lines changed

.revapi/api-changes.json

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,41 @@
6565
"old": "interface io.cucumber.messages.internal.com.google.protobuf.MutabilityOracle",
6666
"new": "interface io.cucumber.messages.internal.com.google.protobuf.MutabilityOracle",
6767
"justification": "Internal API"
68+
},
69+
{
70+
"ignore": true,
71+
"regex": true,
72+
"code": "java\\.method\\.parameterTypeParameterChanged",
73+
"old": "parameter com\\.google\\.inject\\..*",
74+
"new": "parameter com\\.google\\.inject\\..*",
75+
"justification": "Provided dependency"
76+
},
77+
{
78+
"ignore": true,
79+
"regex": true,
80+
"code": "java.class.externalClassExposedInAPI",
81+
"new": "enum com\\.google\\.inject\\..*",
82+
"justification": "Provided dependency"
83+
},
84+
{
85+
"ignore": true,
86+
"regex": true,
87+
"code": "java\\.class\\.externalClassExposedInAPI",
88+
"new": "class com\\.google\\.inject\\..*",
89+
"justification": "Provided dependency"
90+
},
91+
{
92+
"ignore": true,
93+
"code": "java.field.serialVersionUIDUnchanged",
94+
"old": "field com.google.inject.spi.Message.serialVersionUID",
95+
"new": "field com.google.inject.spi.Message.serialVersionUID",
96+
"justification": "Provided dependency"
97+
},
98+
{
99+
"ignore": true,
100+
"code": "java.method.removed",
101+
"old": "method java.util.List<com.google.inject.spi.DependencyAndSource> com.google.inject.spi.ProvisionListener.ProvisionInvocation<T>::getDependencyChain()",
102+
"justification": "Provided dependency"
68103
}
69104
]
70105
}

guice/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
<properties>
1515
<project.Automatic-Module-Name>io.cucumber.guice</project.Automatic-Module-Name>
16-
<guice.version>4.2.3</guice.version>
16+
<guice.version>5.0.1</guice.version>
1717
</properties>
1818

1919
<dependencies>

guice/src/test/java/io/cucumber/guice/GuiceFactoryTest.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
import java.util.List;
2121

2222
import static org.hamcrest.CoreMatchers.notNullValue;
23+
import static org.hamcrest.CoreMatchers.startsWith;
2324
import static org.hamcrest.MatcherAssert.assertThat;
24-
import static org.hamcrest.Matchers.equalToCompressingWhiteSpace;
25-
import static org.hamcrest.core.Is.is;
2625
import static org.junit.jupiter.api.Assertions.assertThrows;
2726

2827
class GuiceFactoryTest {
@@ -71,11 +70,10 @@ void factoryStartFailsIfScenarioScopeIsNotBound() {
7170

7271
Executable testMethod = () -> factory.start();
7372
ConfigurationException actualThrown = assertThrows(ConfigurationException.class, testMethod);
74-
assertThat("Unexpected exception message", actualThrown.getMessage(), is(equalToCompressingWhiteSpace(
75-
"Guice configuration errors:\n\n" +
76-
"1) No implementation for io.cucumber.guice.ScenarioScope was bound.\n" +
77-
" while locating io.cucumber.guice.ScenarioScope\n\n" +
78-
"1 error")));
73+
assertThat("Unexpected exception message", actualThrown.getMessage(), startsWith(
74+
"Guice configuration errors:\n" +
75+
"\n" +
76+
"1) [Guice/MissingImplementation]: No implementation for ScenarioScope was bound."));
7977
}
8078

8179
@Test

0 commit comments

Comments
 (0)