Support delimiter insertion for "paste after"

Author: pokey

src/actions/Actions.ts

@@ -8,7 +8,8 @@ import {
   CopyContentAfter as InsertCopyAfter,
   CopyContentBefore as InsertCopyBefore,
 } from "./InsertCopy";
-import { Copy, Cut, Paste } from "./CutCopyPaste";
+import { Copy, Cut } from "./CutCopy";
+import { Paste } from "./Paste";
 import Deselect from "./Deselect";
 import { EditNewBefore, EditNewAfter } from "./EditNew";
 import ExecuteCommand from "./ExecuteCommand";

src/actions/CutCopyPaste.ts renamed to src/actions/CutCopy.ts

@@ -60,13 +60,3 @@ export class Copy extends CommandAction {
     });
   }
 }
-
-export class Paste extends CommandAction {
-  constructor(graph: Graph) {
-    super(graph, {
-      command: "editor.action.clipboardPasteAction",
-      ensureSingleEditor: true,
-      showDecorations: true,
-    });
-  }
-}

src/actions/Paste.ts

@@ -0,0 +1,83 @@
+import { commands, DecorationRangeBehavior, window } from "vscode";
+import {
+  callFunctionAndUpdateSelections,
+  callFunctionAndUpdateSelectionsWithBehavior,
+} from "../core/updateSelections/updateSelections";
+import { Target } from "../typings/target.types";
+import { Graph } from "../typings/Types";
+import {
+  focusEditor,
+  setSelectionsWithoutFocusingEditor,
+} from "../util/setSelectionsAndFocusEditor";
+import { ensureSingleEditor } from "../util/targetUtils";
+import { ActionReturnValue } from "./actions.types";
+import { EditNew } from "./EditNew";
+
+export class Paste {
+  private editNewAction: EditNew;
+
+  constructor(private graph: Graph) {
+    this.editNewAction = new EditNew(graph);
+  }
+
+  async run([targets]: [Target[]]): Promise<ActionReturnValue> {
+    const targetEditor = ensureSingleEditor(targets);
+    const originalEditor = window.activeTextEditor;
+
+    const [originalCursorSelections] = await callFunctionAndUpdateSelections(
+      this.graph.rangeUpdater,
+      async () => {
+        await this.editNewAction.run([targets]);
+      },
+      targetEditor.document,
+      [targetEditor.selections]
+    );
+
+    const originalTargetSelections = {
+      selections: targetEditor.selections,
+      rangeBehavior: DecorationRangeBehavior.OpenOpen,
+    };
+
+    const [updatedCursorSelections, updatedTargetSelections] =
+      await callFunctionAndUpdateSelectionsWithBehavior(
+        this.graph.rangeUpdater,
+        () => commands.executeCommand("editor.action.clipboardPasteAction"),
+        targetEditor.document,
+        [
+          {
+            selections: originalCursorSelections,
+          },
+          originalTargetSelections,
+        ]
+      );
+
+    // Reset original selections
+    // NB: We don't focus the editor here because we'll do that at the
+    // very end.
+    setSelectionsWithoutFocusingEditor(targetEditor, updatedCursorSelections);
+
+    // If necessary focus back original editor
+    if (originalEditor != null && originalEditor !== window.activeTextEditor) {
+      // NB: We just do one editor focus at the end, instead of using
+      // setSelectionsAndFocusEditor because the command might operate on
+      // multiple editors, so we just do one focus at the end.
+      await focusEditor(originalEditor);
+    }
+
+    this.graph.editStyles.displayPendingEditDecorationsForRanges(
+      updatedTargetSelections.map((selection) => ({
+        editor: targetEditor,
+        range: selection,
+      })),
+      this.graph.editStyles.justAdded,
+      true
+    );
+
+    return {
+      thatMark: updatedTargetSelections.map((selection) => ({
+        editor: targetEditor,
+        selection,
+      })),
+    };
+  }
+}

src/core/updateSelections/updateSelections.ts

@@ -186,7 +186,7 @@ export async function callFunctionAndUpdateRanges(
  * @param rangeUpdater A RangeUpdate instance that will perform actual range updating
  * @param func The function to call
  * @param document The document containing the selections
- * @param selectionMatrix A matrix of selection info objects to update
+ * @param selectionInfoMatrix A matrix of selection info objects to update
  * @returns The initial selections updated based upon what happened in the function
  */
 async function callFunctionAndUpdateSelectionInfos(
@@ -207,6 +207,38 @@ async function callFunctionAndUpdateSelectionInfos(
   return selectionInfosToSelections(selectionInfoMatrix);
 }
 
+/**
+ * Performs a list of edits and returns the given selections updated based on
+ * the applied edits
+ * @param rangeUpdater A RangeUpdate instance that will perform actual range updating
+ * @param func The function to call
+ * @param document The document containing the selections
+ * @param originalSelections The selections to update
+ * @returns The updated selections
+ */
+export function callFunctionAndUpdateSelectionsWithBehavior(
+  rangeUpdater: RangeUpdater,
+  func: () => Thenable<void>,
+  document: TextDocument,
+  originalSelections: SelectionsWithBehavior[]
+) {
+  return callFunctionAndUpdateSelectionInfos(
+    rangeUpdater,
+    func,
+    document,
+    originalSelections.map((selectionsWithBehavior) =>
+      selectionsWithBehavior.selections.map((selection) =>
+        getSelectionInfo(
+          document,
+          selection,
+          selectionsWithBehavior.rangeBehavior ??
+            DecorationRangeBehavior.ClosedClosed
+        )
+      )
+    )
+  );
+}
+
 /**
  * Performs a list of edits and returns the given selections updated based on
  * the applied edits

src/processTargets/targets/BaseTarget.ts

@@ -147,13 +147,30 @@ export default abstract class BaseTarget implements Target {
     );
   }
 
-  isEqual(target: Target): boolean {
+  isEqual(otherTarget: Target): boolean {
     return (
-      target instanceof BaseTarget &&
-      isEqual(this.getCloneParameters(), target.getCloneParameters())
+      otherTarget instanceof BaseTarget &&
+      isEqual(this.getEqualityParameters(), otherTarget.getEqualityParameters())
     );
   }
 
+  /**
+   * @returns An object that can be used for determining equality between two
+   * `BaseTarget`s
+   */
+  protected getEqualityParameters() {
+    const { thatTarget, ...otherCloneParameters } =
+      this.getCloneParameters() as { thatTarget?: Target };
+    if (!(thatTarget instanceof BaseTarget)) {
+      return { thatTarget, ...otherCloneParameters };
+    }
+
+    return {
+      thatTarget: thatTarget ? thatTarget.getCloneParameters() : undefined,
+      ...otherCloneParameters,
+    };
+  }
+
   toPositionTarget(position: Position): Target {
     return toPositionTarget(this, position);
   }

src/test/suite/fixtures/recorded/actions/pasteAfterArgue.yml

@@ -0,0 +1,27 @@
+languageId: typescript
+command:
+  spokenForm: paste after argue
+  version: 2
+  targets:
+    - type: primitive
+      modifiers:
+        - {type: position, position: after}
+        - type: containingScope
+          scopeType: {type: argumentOrParameter}
+  usePrePhraseSnapshot: true
+  action: {name: pasteFromClipboard}
+initialState:
+  documentContents: foo(bar, baz, bongo)
+  selections:
+    - anchor: {line: 0, character: 17}
+      active: {line: 0, character: 17}
+  marks: {}
+finalState:
+  documentContents: foo(bar, baz, bongo, baz)
+  selections:
+    - anchor: {line: 0, character: 17}
+      active: {line: 0, character: 17}
+  thatMark:
+    - anchor: {line: 0, character: 21}
+      active: {line: 0, character: 24}
+fullTargets: [{type: primitive, mark: {type: cursor}, modifiers: [{type: position, position: after}, {type: containingScope, scopeType: {type: argumentOrParameter}}]}]

src/test/suite/fixtures/recorded/actions/pasteAfterState.yml

@@ -0,0 +1,33 @@
+languageId: typescript
+command:
+  spokenForm: paste after state
+  version: 2
+  targets:
+    - type: primitive
+      modifiers:
+        - {type: position, position: after}
+        - type: containingScope
+          scopeType: {type: statement}
+  usePrePhraseSnapshot: true
+  action: {name: pasteFromClipboard}
+initialState:
+  documentContents: const whatever = "hello";
+  selections:
+    - anchor: {line: 0, character: 9}
+      active: {line: 0, character: 9}
+    - anchor: {line: 0, character: 21}
+      active: {line: 0, character: 21}
+  marks: {}
+finalState:
+  documentContents: |-
+    const whatever = "hello";
+    const whatever = "hello";
+  selections:
+    - anchor: {line: 0, character: 9}
+      active: {line: 0, character: 9}
+    - anchor: {line: 0, character: 21}
+      active: {line: 0, character: 21}
+  thatMark:
+    - anchor: {line: 1, character: 0}
+      active: {line: 1, character: 25}
+fullTargets: [{type: primitive, mark: {type: cursor}, modifiers: [{type: position, position: after}, {type: containingScope, scopeType: {type: statement}}]}]

src/test/suite/fixtures/recorded/actions/pasteBeforeArgue.yml

@@ -0,0 +1,27 @@
+languageId: typescript
+command:
+  spokenForm: paste before argue
+  version: 2
+  targets:
+    - type: primitive
+      modifiers:
+        - {type: position, position: before}
+        - type: containingScope
+          scopeType: {type: argumentOrParameter}
+  usePrePhraseSnapshot: true
+  action: {name: pasteFromClipboard}
+initialState:
+  documentContents: foo(bar, baz, bongo)
+  selections:
+    - anchor: {line: 0, character: 17}
+      active: {line: 0, character: 17}
+  marks: {}
+finalState:
+  documentContents: foo(bar, baz, baz, bongo)
+  selections:
+    - anchor: {line: 0, character: 22}
+      active: {line: 0, character: 22}
+  thatMark:
+    - anchor: {line: 0, character: 14}
+      active: {line: 0, character: 17}
+fullTargets: [{type: primitive, mark: {type: cursor}, modifiers: [{type: position, position: before}, {type: containingScope, scopeType: {type: argumentOrParameter}}]}]

src/test/suite/fixtures/recorded/actions/pasteBeforeState.yml

@@ -0,0 +1,33 @@
+languageId: typescript
+command:
+  spokenForm: paste before state
+  version: 2
+  targets:
+    - type: primitive
+      modifiers:
+        - {type: position, position: before}
+        - type: containingScope
+          scopeType: {type: statement}
+  usePrePhraseSnapshot: true
+  action: {name: pasteFromClipboard}
+initialState:
+  documentContents: const whatever = "hello";
+  selections:
+    - anchor: {line: 0, character: 9}
+      active: {line: 0, character: 9}
+    - anchor: {line: 0, character: 21}
+      active: {line: 0, character: 21}
+  marks: {}
+finalState:
+  documentContents: |-
+    const whatever = "hello";
+    const whatever = "hello";
+  selections:
+    - anchor: {line: 1, character: 9}
+      active: {line: 1, character: 9}
+    - anchor: {line: 1, character: 21}
+      active: {line: 1, character: 21}
+  thatMark:
+    - anchor: {line: 0, character: 0}
+      active: {line: 0, character: 25}
+fullTargets: [{type: primitive, mark: {type: cursor}, modifiers: [{type: position, position: before}, {type: containingScope, scopeType: {type: statement}}]}]