Skip to content

Migrate surroundingPair to use a scope handler #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
Tracked by #1052
pokey opened this issue Oct 21, 2022 · 1 comment
Closed
3 tasks
Tracked by #1052

Migrate surroundingPair to use a scope handler #1061

pokey opened this issue Oct 21, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@pokey
Copy link
Member

pokey commented Oct 21, 2022

We probably actually want three different versions of this scope handler (could prob just be flags on the scope type object itself)

  • The usual one where the domain and content range are the full surrounding pair
  • One where the domain is the full surrounding pair, but content range is "Inside", excluding whitespace
  • One where the domain is "inside", including whitespace, and content range is "Inside", excluding whitespace
@AndreasArvidsson
Copy link
Member

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants