Skip to content

Automatic token expansion doesn't work if token is offscreen #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pokey opened this issue Oct 17, 2021 · 0 comments · Fixed by #306
Closed

Automatic token expansion doesn't work if token is offscreen #298

pokey opened this issue Oct 17, 2021 · 0 comments · Fixed by #306
Labels
bug Something isn't working
Milestone
0.24.0

Comments

@pokey
Copy link
Member

pokey commented Oct 17, 2021 •
edited
Loading

Steps to reproduce

  1. Put your cursor in the middle of a token
  2. Scroll the token off the screen
  3. Say "chuck first word"

Root cause

We use the navigation map to get tokens and the navigation map only has tokens that are on screen.

Proposed solution

Tokenise the line containing the start of the range and the line containing the end of the range and use those tokens
@pokey pokey added the bug Something isn't working label Oct 17, 2021
@pokey pokey added this to the 0.23.0 milestone Oct 17, 2021
@pokey pokey modified the milestones: 0.23.0, 0.24.0 Oct 27, 2021
@pokey pokey mentioned this issue Nov 3, 2021
Merged
1 task
@pokey pokey mentioned this issue May 18, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Improved update selections cursorless-dev/cursorless
1 participant
@pokey