Skip to content

Allow pipeline stages to run without a context #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pokey opened this issue Jun 23, 2022 · 2 comments
Closed

Allow pipeline stages to run without a context #785

pokey opened this issue Jun 23, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@pokey
Copy link
Member

pokey commented Jun 23, 2022

In order to expand the places where we can use modifier stages we'd like to remove the necessity to pass a context object into the run method. This would allow us, for example, to determine what scope we're in when we are inserting a snippet.

The notion that processedTargetsContext completely captures the state of the environment is an illusion anyway, since a target already has access to an editor, which we use in multiple places.

Instead, we should pass the graph object into a modifier stage when we construct it.

@AndreasArvidsson
Copy link
Member

We also needs to pass the graph into our new scope handlers as well as the tokenizer. In fact these should probably migrate into the graph.

@pokey pokey closed this as completed in 467f699 Apr 19, 2023
@pokey pokey reopened this Apr 19, 2023
@pokey
Copy link
Member Author

pokey commented May 20, 2023

closed by #1477

@pokey pokey closed this as completed May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants