Skip to content

Commit 00ea3de

Browse files
cacieprinsmschile
andauthored
test: temporarily disable beforeEach assertion in issue 1244 regression test (#29288)
* misc: bump cache * misc: temporarily disable issue 1244 tests to fix ci * reenable 1244 tests, just comment out counters assertion * Update packages/driver/cypress/e2e/issues/1244.cy.js Co-authored-by: Matt Schile <[email protected]> --------- Co-authored-by: Matt Schile <[email protected]>
1 parent 7410909 commit 00ea3de

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

.circleci/cache-version.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Bump this version to force CI to re-create the cache from scratch.
22

3-
04-2-24
3+
04-8-24

packages/driver/cypress/e2e/issues/1244.cy.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,14 @@ describe('issue 1244', () => {
66

77
// not all pages that get unloaded during this spec have getCounters()
88
if (win.location.href.includes('issue-1244.html')) {
9-
expect(win.getCounters()).to.deep.equal({ getCounter: 0, setCounter: 0 })
9+
// TODO: re-enable when capture completes dom transition.
10+
// getCounters is changed when setAttribute/getAttribute
11+
// is called which is necessary for certain capture code to work.
12+
// once dom transition is complete, that capture code will no
13+
// longer rely on setAttribute/getAttribute.
14+
// see: https://github.com/cypress-io/cypress-services/issues/7725
15+
16+
// expect(win.getCounters()).to.deep.equal({ getCounter: 0, setCounter: 0 })
1017
}
1118
})
1219
})

0 commit comments

Comments
 (0)