Use revive instead of golint

Signed-off-by: pigletfly <[email protected]>

Author: pigletfly

.github/workflows/components-contrib.yml

@@ -33,7 +33,7 @@ jobs:
       GOOS: ${{ matrix.target_os }}
       GOARCH: ${{ matrix.target_arch }}
       GOPROXY: https://proxy.golang.org
-      GOLANGCI_LINT_VER: v1.31
+      GOLANGCI_LINT_VER: v1.45.2
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest, macOS-latest]

.golangci.yml

@@ -28,7 +28,7 @@ run:
   # won't be reported. Default value is empty list, but there is
   # no need to include all autogenerated files, we confidently recognize
   # autogenerated files. If it's not please let us know.
-  skip-files:
+  # skip-files:
   #  - ".*\\.my\\.go$"
   #  - lib/bad.go
 
@@ -62,7 +62,7 @@ linters-settings:
 
     # path to a file containing a list of functions to exclude from checking
     # see https://github.com/kisielk/errcheck#excluding-functions for details
-    exclude:
+    # exclude:
 
   funlen:
     lines: 60
@@ -88,9 +88,9 @@ linters-settings:
     disable:
       - shadow
     disable-all: false
-  golint:
+  revive:
     # minimal confidence for issues, default is 0.8
-    min-confidence: 0.8
+    confidence: 0.8
   gofmt:
     # simplify code: gofmt with `-s` option, true by default
     simplify: true
@@ -127,7 +127,7 @@ linters-settings:
     # Correct spellings using locale preferences for US or UK.
     # Default is to use a neutral variety of English.
     # Setting locale to US will correct the British spelling of 'colour' to 'color'.
-    locale: default
+    locale: US
     ignore-words:
       - someword
   lll:
@@ -165,7 +165,7 @@ linters-settings:
     # See https://go-critic.github.io/overview#checks-overview
     # To check which checks are enabled run `GL_DEBUG=gocritic golangci-lint run`
     # By default list of stable checks is used.
-    enabled-checks:
+    # enabled-checks:
 
     # Which checks should be disabled; can't be combined with 'enabled-checks'; default is empty
     disabled-checks:
@@ -246,3 +246,4 @@ linters:
     - exhaustive
     - noctx
     - gci
+    - golint

bindings/http/http.go

@@ -33,7 +33,7 @@ import (
 )
 
 // HTTPSource is a binding for an http url endpoint invocation
-// nolint:golint
+//revive:disable-next-line
 type HTTPSource struct {
 	metadata httpMetadata
 	client   *http.Client

nameresolution/consul/configuration.go

@@ -327,7 +327,7 @@ func mapAdvancedRegistration(config *AgentServiceRegistration) *consul.AgentServ
 	return mapped
 }
 
-//nolint:golint,stylecheck
+//revive:disable-next-line
 type HttpBasicAuth struct {
 	Username string
 	Password string
@@ -337,11 +337,12 @@ type Config struct {
 	Address    string
 	Scheme     string
 	Datacenter string
-	HttpAuth   *HttpBasicAuth //nolint:golint,stylecheck
-	WaitTime   time.Duration
-	Token      string
-	TokenFile  string
-	TLSConfig  TLSConfig
+	//revive:disable-next-line
+	HttpAuth  *HttpBasicAuth
+	WaitTime  time.Duration
+	Token     string
+	TokenFile string
+	TLSConfig TLSConfig
 }
 
 type TLSConfig struct {

pubsub/azure/servicebus/message.go

@@ -114,7 +114,6 @@ func NewPubsubMessageFromASBMessage(asbMsg *azservicebus.Message, topic string)
 	// Always set delivery count.
 	addToMetadata(pubsubMsg, DeliveryCountMetadataKey, strconv.FormatInt(int64(asbMsg.DeliveryCount), 10))
 
-	//nolint:golint,nestif
 	if asbMsg.SystemProperties != nil {
 		systemProps := asbMsg.SystemProperties
 		if systemProps.EnqueuedTime != nil {

state/redis/redis.go

@@ -403,7 +403,6 @@ func (r *StateStore) Multi(request *state.TransactionalStateRequest) error {
 
 	pipe := r.client.TxPipeline()
 	for _, o := range request.Operations {
-		//nolint:golint,nestif
 		if o.Operation == state.Upsert {
 			req := o.Request.(state.SetRequest)
 			ver, err := r.parseETag(&req)