Skip to content

Commit 12f1150

Browse files
committed
Address comments
Signed-off-by: siri-varma <[email protected]>
1 parent bbb5d1b commit 12f1150

File tree

24 files changed

+103
-50
lines changed

24 files changed

+103
-50
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<grpc.version>1.69.0</grpc.version>
1818
<protobuf.version>3.25.5</protobuf.version>
1919
<protocCommand>protoc</protocCommand>
20-
<dapr.proto.baseurl>https://github.com/raw/dapr/dapr/v1.15.3/dapr/proto</dapr.proto.baseurl>
20+
<dapr.proto.baseurl>https://github.com/raw/dapr/dapr/v1.15.4/dapr/proto</dapr.proto.baseurl>
2121
<dapr.sdk.version>1.15.0-SNAPSHOT</dapr.sdk.version>
2222
<dapr.sdk.alpha.version>0.15.0-SNAPSHOT</dapr.sdk.alpha.version>
2323
<os-maven-plugin.version>1.7.1</os-maven-plugin.version>

sdk-springboot/src/test/java/io/dapr/springboot/MockController.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313

1414
package io.dapr.springboot;
1515

16-
import org.springframework.web.bind.annotation.*;
16+
import org.springframework.web.bind.annotation.PostMapping;
17+
import org.springframework.web.bind.annotation.RequestMapping;
18+
import org.springframework.web.bind.annotation.RequestMethod;
1719

1820
@RequestMapping(value = {"v1", "v2"})
1921
public class MockController {

sdk-tests/src/test/java/io/dapr/it/resiliency/SdkResiliencyIT.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@
5858
import static com.github.tomakehurst.wiremock.client.WireMock.urlMatching;
5959
import static com.github.tomakehurst.wiremock.client.WireMock.verify;
6060
import static io.dapr.it.resiliency.SdkResiliencyIT.WIREMOCK_PORT;
61-
import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
62-
import static io.dapr.it.testcontainers.ContainerConstants.TOXIPROXY_IMAGE_TAG;
61+
import static io.dapr.it.testcontainers.DaprContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
6362
import static org.assertj.core.api.Assertions.assertThat;
6463
import static org.junit.jupiter.api.Assertions.assertThrows;
6564

@@ -85,7 +84,7 @@ public class SdkResiliencyIT {
8584
.withNetwork(NETWORK);
8685

8786
@Container
88-
private static final ToxiproxyContainer TOXIPROXY = new ToxiproxyContainer(TOXIPROXY_IMAGE_TAG)
87+
private static final ToxiproxyContainer TOXIPROXY = new ToxiproxyContainer("ghcr.io/shopify/toxiproxy:2.5.0")
8988
.withNetwork(NETWORK);
9089

9190
private static Proxy proxy;

sdk-tests/src/test/java/io/dapr/it/spring/data/DaprKeyValueRepositoryIT.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,10 @@
3535

3636
import static io.dapr.it.spring.data.DaprSpringDataConstants.BINDING_NAME;
3737
import static io.dapr.it.spring.data.DaprSpringDataConstants.STATE_STORE_NAME;
38-
import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
39-
import static org.junit.jupiter.api.Assertions.*;
38+
import static io.dapr.it.testcontainers.DaprContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
39+
import static org.junit.jupiter.api.Assertions.assertEquals;
40+
import static org.junit.jupiter.api.Assertions.assertFalse;
41+
import static org.junit.jupiter.api.Assertions.assertTrue;
4042

4143
/**
4244
* Integration tests for {@link DaprKeyValueRepositoryIT}.

sdk-tests/src/test/java/io/dapr/it/spring/data/MySQLDaprKeyValueTemplateIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
import static io.dapr.it.spring.data.DaprSpringDataConstants.STATE_STORE_NAME;
4646
import static io.dapr.it.spring.data.DaprSpringDataConstants.BINDING_NAME;
47-
import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
47+
import static io.dapr.it.testcontainers.DaprContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
4848
import static org.assertj.core.api.Assertions.assertThat;
4949
import static org.junit.jupiter.api.Assertions.assertEquals;
5050

sdk-tests/src/test/java/io/dapr/it/spring/data/PostgreSQLDaprKeyValueTemplateIT.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,15 @@
3232
import org.testcontainers.junit.jupiter.Container;
3333
import org.testcontainers.junit.jupiter.Testcontainers;
3434

35-
import java.util.*;
35+
import java.util.ArrayList;
36+
import java.util.HashMap;
37+
import java.util.List;
38+
import java.util.Map;
39+
import java.util.Optional;
3640

3741
import static io.dapr.it.spring.data.DaprSpringDataConstants.BINDING_NAME;
3842
import static io.dapr.it.spring.data.DaprSpringDataConstants.STATE_STORE_NAME;
39-
import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
43+
import static io.dapr.it.testcontainers.DaprContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
4044
import static org.assertj.core.api.Assertions.assertThat;
4145
import static org.junit.jupiter.api.Assertions.assertEquals;
4246

sdk-tests/src/test/java/io/dapr/it/spring/messaging/DaprSpringMessagingIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import java.util.Collections;
3838
import java.util.List;
3939

40-
import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
40+
import static io.dapr.it.testcontainers.DaprContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
4141
import static org.assertj.core.api.Assertions.assertThat;
4242

4343
@SpringBootTest(

sdk-tests/src/test/java/io/dapr/it/testcontainers/ContainerConstants.java

Lines changed: 0 additions & 9 deletions
This file was deleted.

sdk-tests/src/test/java/io/dapr/it/testcontainers/DaprActorsIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import java.util.Random;
3838
import java.util.UUID;
3939

40-
import static io.dapr.it.testcontainers.ContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
40+
import static io.dapr.it.testcontainers.DaprContainerConstants.DAPR_RUNTIME_IMAGE_TAG;
4141
import static org.junit.jupiter.api.Assertions.assertEquals;
4242

4343
@SpringBootTest(
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package io.dapr.it.testcontainers;
2+
3+
public interface DaprContainerConstants {
4+
String DAPR_RUNTIME_VERSION = "1.15.4";
5+
String DAPR_RUNTIME_IMAGE_TAG = "daprio/daprd:" + DAPR_RUNTIME_VERSION;
6+
String DAPR_PLACEMENT_IMAGE_TAG = "daprio/placement:" + DAPR_RUNTIME_VERSION;
7+
String DAPR_SCHEDULER_IMAGE_TAG = "daprio/scheduler:" + DAPR_RUNTIME_VERSION;
8+
}

0 commit comments

Comments
 (0)