Merge pull request #37 from sublimino/dev

Return exit code 0 on delayed child process error

Author: keithamus

index.js

@@ -76,7 +76,7 @@ function close (code) {
     var i, len, closeHandler, closed = 0, opened = 0;
 
     for (i = 0, len = children.length; i < len; i++) {
-        if (!children[i].exitCode) {
+        if (children[i].exitCode === null) {
             opened++;
             children[i].removeAllListeners('close');
             if (process.platform != "win32") {

test/index.coffee

@@ -16,6 +16,8 @@ else
 # children
 waitingProcess = (time=10000) ->
   return "\"node -e 'setTimeout(function(){},#{time});'\""
+waitingFailingProcess = (time=10000) ->
+  return "\"node -e 'setTimeout(function(){ throw new Error(); },#{time});'\""
 failingProcess = "\"node -e 'throw new Error();'\""
 
 usageInfo = """
@@ -86,6 +88,13 @@ describe "parallelshell", ->
       ps.exitCode.should.equal 1
       done()
 
+  it "should close with exitCode 1 on delayed child error", (done) ->
+    ps = spawnParallelshell([waitingFailingProcess(100),waitingProcess(1),waitingProcess(500)].join(" "))
+    spyOnPs ps, 2
+    ps.on "exit", () ->
+      ps.exitCode.should.equal 1
+      done()
+
   it "should run with a normal child", (done) ->
     ps = spawnParallelshell(waitingProcess())
     spyOnPs ps, 1
@@ -96,7 +105,6 @@ describe "parallelshell", ->
       killPs(ps)
     ),150
 
-
   it "should close sibling processes on child error", (done) ->
     ps = spawnParallelshell([waitingProcess(),failingProcess].join(" "))
     spyOnPs ps,2