style: code cleanup

Author: vicb

lib/core_dom/dom_util.dart

@@ -38,7 +38,7 @@ List<dom.Node> allNodesBetween(List<dom.Node> nodes) {
   // Not every element is sequential if the list of nodes only
   // includes the elements. Removing a view also includes
   // removing non-element nodes in-between.
-  for (var j = 0, jj = nodes.length; j < jj; j++) {
+  for (var j = 0; j < nodes.length; j++) {
     dom.Node current = nodes[j];
     dom.Node next = j + 1 < nodes.length ? nodes[j + 1] : null;
 

lib/core_dom/element_binder.dart

@@ -83,7 +83,7 @@ class ElementBinder {
   bool get hasDirectivesOrEvents =>
       _usableDirectiveRefs.isNotEmpty || onEvents.isNotEmpty;
 
-  _bindTwoWay(tasks, expression, scope, dstPathFn, controller, formatters, dstExpression) {
+  void _bindTwoWay(tasks, expression, scope, dstPathFn, controller, formatters, dstExpression) {
     var taskId = tasks.registerTask();
     Expression expressionFn = _parser(expression);
 
@@ -120,11 +120,13 @@ class ElementBinder {
     }, formatters: formatters);
   }
 
-  _bindCallback(dstPathFn, controller, expression, scope) {
+  void _bindCallback(dstPathFn, controller, expression, scope) {
     dstPathFn.assign(controller, _parser(expression).bind(scope.context, ScopeLocals.wrapper));
   }
 
-  _createAttrMappings(directive, scope, List<MappingParts> mappings, nodeAttrs, formatters, tasks) {
+
+  void _createAttrMappings(directive, scope, List<MappingParts> mappings, nodeAttrs, formatters,
+                           tasks) {
     mappings.forEach((MappingParts p) {
       var attrName = p.attrName;
       var dstExpression = p.dstExpression;
@@ -199,7 +201,7 @@ class ElementBinder {
     });
   }
 
-  _link(nodeInjector, probe, scope, nodeAttrs, formatters) {
+  void _link(nodeInjector, probe, scope, nodeAttrs, formatters) {
     _usableDirectiveRefs.forEach((DirectiveRef ref) {
       var linkTimer;
       try {
@@ -245,8 +247,8 @@ class ElementBinder {
     });
   }
 
-  _createDirectiveFactories(DirectiveRef ref, nodeModule, node, nodesAttrsDirectives, nodeAttrs,
-                            visibility) {
+  void _createDirectiveFactories(DirectiveRef ref, nodeModule, node, nodesAttrsDirectives, nodeAttrs,
+                                 visibility) {
     if (ref.type == TextMustache) {
       nodeModule.bind(TextMustache, toFactory: (Injector injector) {
         return new TextMustache(node, ref.value, injector.get(Interpolate),
@@ -281,7 +283,7 @@ class ElementBinder {
   }
 
   // Overridden in TemplateElementBinder
-  _registerViewFactory(node, parentInjector, nodeModule) {
+  void _registerViewFactory(node, parentInjector, nodeModule) {
     nodeModule..bind(ViewPort, toValue: null)
               ..bind(ViewFactory, toValue: null)
               ..bind(BoundViewFactory, toValue: null);
@@ -348,7 +350,7 @@ class ElementBinder {
  * Private class used for managing controller.attach() calls
  */
 class _TaskList {
-  var onDone;
+  Function onDone;
   final List _tasks = [];
   bool isDone = false;
 
@@ -371,7 +373,7 @@ class _TaskList {
     }
   }
 
-  doneRegistering() {
+  void doneRegistering() {
     completeTask(registerTask());
   }
 }
@@ -396,7 +398,7 @@ class TaggedTextBinder {
   final int offsetIndex;
 
   TaggedTextBinder(this.binder, this.offsetIndex);
-  toString() => "[TaggedTextBinder binder:$binder offset:$offsetIndex]";
+  String toString() => "[TaggedTextBinder binder:$binder offset:$offsetIndex]";
 }
 
 // Used for the tagging compiler
@@ -414,6 +416,8 @@ class TaggedElementBinder {
     textBinders.add(tagged);
   }
 
+  bool get isDummy => binder == null && textBinders == null && !isTopLevel;
+
   String toString() => "[TaggedElementBinder binder:$binder parentBinderOffset:"
                        "$parentBinderOffset textBinders:$textBinders]";
 }

lib/core_dom/element_binder_builder.dart

@@ -31,7 +31,7 @@ class ElementBinderFactory {
  * building ElementBinders.
  */
 class ElementBinderBuilder {
-  static RegExp _MAPPING = new RegExp(r'^(\@|=\>\!|\=\>|\<\=\>|\&)\s*(.*)$');
+  static final RegExp _MAPPING = new RegExp(r'^(@|=>!|=>|<=>|&)\s*(.*)$');
 
   ElementBinderFactory _factory;
 
@@ -40,7 +40,7 @@ class ElementBinderBuilder {
   /// "bind-*" attribute names and values, added by a [DirectiveSelector]
   final bindAttrs = <String, String>{};
 
-  var decorators = <DirectiveRef>[];
+  final decorators = <DirectiveRef>[];
   DirectiveRef template;
   DirectiveRef component;
 
@@ -74,18 +74,20 @@ class ElementBinderBuilder {
       childMode = annotation.children;
     }
 
-    if (annotation.map != null) annotation.map.forEach((attrName, mapping) {
-      Match match = _MAPPING.firstMatch(mapping);
-      if (match == null) {
-        throw "Unknown mapping '$mapping' for attribute '$attrName'.";
-      }
-      var mode = match[1];
-      var dstPath = match[2];
+    if (annotation.map != null) {
+      annotation.map.forEach((attrName, mapping) {
+        Match match = _MAPPING.firstMatch(mapping);
+        if (match == null) {
+          throw "Unknown mapping '$mapping' for attribute '$attrName'.";
+        }
+        var mode = match[1];
+        var dstPath = match[2];
 
-      String dstExpression = dstPath.isEmpty ? attrName : dstPath;
+        String dstExpression = dstPath.isEmpty ? attrName : dstPath;
 
-      ref.mappings.add(new MappingParts(attrName, mode, dstExpression, mapping));
-    });
+        ref.mappings.add(new MappingParts(attrName, mode, dstExpression, mapping));
+      });
+    }
   }
 
   /// Creates an returns an [ElementBinder] or a [TemplateElementBinder]