more signatures

Author: ochafik

lib/src/closure/closure_codegen.dart

@@ -117,7 +117,7 @@ abstract class ClosureCodegen {
       if (type.namedParameterTypes.isNotEmpty) {
         var namedArgs = <String, ClosureType>{};
         type.namedParameterTypes.forEach((n, t) {
-          namedArgs[n] = _closureTypeForDartType(t);
+          namedArgs[n] = _closureTypeForDartType(t).orUndefined();
         });
         args.add(new ClosureType.record(namedArgs).toOptional());
       }

test/codegen/closure.dart

@@ -22,6 +22,8 @@ class Foo {
 
   nullary_method() {}
 
+  function_params(int f(x, [y]), g(x, {String y})) {}
+
   String get prop => null;
   set prop(String value) {}
 

test/codegen/expect/closure.js

@@ -56,6 +56,11 @@ dart_library.library('closure', null, /* Imports */[
       let c = opts && 'c' in opts ? opts.c : null;
     }
     nullary_method() {}
+    /**
+     * @param {function(*, *=):?number} f
+     * @param {function(*, {y: (string|undefined)}=):*} g
+     */
+    function_params(f, g) {}
     /** @return {string} */
     get prop() {
       return null;
@@ -75,7 +80,8 @@ dart_library.library('closure', null, /* Imports */[
       untyped_method: [dart.dynamic, [dart.dynamic, dart.dynamic]],
       typed_method: [core.String, [Foo, core.List, core.int, core.num, core.double, core.bool, core.String, js.JsArray, js.JsObject, js.JsFunction]],
       optional_params: [dart.dynamic, [dart.dynamic], [dart.dynamic, dart.dynamic]],
-      nullary_method: [dart.dynamic, []]
+      nullary_method: [dart.dynamic, []],
+      function_params: [dart.dynamic, [dart.functionType(core.int, [dart.dynamic], [dart.dynamic]), dart.functionType(dart.dynamic, [dart.dynamic], {y: core.String})]]
     }),
     statics: () => ({named_params: [dart.dynamic, [dart.dynamic], {b: dart.dynamic, c: dart.dynamic}]}),
     names: ['named_params']