Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

remove all uses of element.node #32

Closed
sigmundch opened this issue Jan 26, 2015 · 3 comments
Closed

remove all uses of element.node #32

sigmundch opened this issue Jan 26, 2015 · 3 comments

Comments

@sigmundch
Copy link
Contributor

element.node is not cached, it can trigger reparsing ASTs and remapping nodes to their elements. It's recommended that we don't use it.

The CL at https://chromereviews.googleplex.com/143177014/ gets rid of most of the uses except 2:

  • driving the codegen: this can be fixed easily once we change the compiler to have a pipeline (check-generate, check-generate). The logic in the checker for visiting units would then be enough to handle this
  • determine some information about constant fields from the js codegen. I still need to look further into this one.
@jmesserly
Copy link
Contributor

second one is fixed in https://chromereviews.googleplex.com/147927013/
edit: landed as b1b36fe

@sigmundch
Copy link
Contributor Author

and the former one will be fixed here: https://chromereviews.googleplex.com/145167013/

@jmesserly
Copy link
Contributor

since both fixes landed, assuming this is now closed :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants