Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

refactor visitBinaryExpression and similar methods #46

Closed
jmesserly opened this issue Feb 13, 2015 · 2 comments
Closed

refactor visitBinaryExpression and similar methods #46

jmesserly opened this issue Feb 13, 2015 · 2 comments
Labels
Type: code health Type: enhancement

Comments

@jmesserly
Copy link
Contributor

right now in the compiler, we have a lot of special cases in methods like visitBinary ... it would be nice if we could factor this better, so codegen for statically known call sites is more uniform.
@jmesserly jmesserly added the js label Feb 13, 2015
@jmesserly jmesserly changed the title more uniform calling conventions refactor visitBinaryExpression and similar methods Feb 13, 2015
@jmesserly
Copy link
Contributor Author

this is in pretty shape good now, though it would still be nice to inline call sites from dart:core rather than hard coding.

@jmesserly
Copy link
Contributor Author

Eh, I'm going to say good enough for now. Might be worth revisiting at some point, but we haven't needed to many tweaks in the visit* code lately.

@kzhdev kzhdev mentioned this issue Feb 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: code health Type: enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmesserly